search

valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Outputs comparison suite data to json and AtmosCO2 #129

Closed ledm closed 2 months ago

ledm commented 2 months ago

Two major changes:

  1. A new function that output time series data as a json file, which can then be easily exported outside bgcval (or even out of python).
  2. A new field for atmospheric CO2, AtmosCO2, is now included in bgval2 by default, as TF are all running in emissions.
ledm commented 2 months ago

The tests arefailing because I added a new import: jsondiff. @valeriupredoi, how do I fix that?

valeriupredoi commented 2 months ago

this the package you added? https://anaconda.org/conda-forge/jsondiff

ledm commented 2 months ago

Looks like that works, good job V.

valeriupredoi commented 2 months ago

no failed test can ever stand a chance against me, bud :grin:

ledm commented 2 months ago

Ready for review @valeriupredoi!

valeriupredoi commented 2 months ago

Ready for review @valeriupredoi!

on it right now, buds :beer:

ledm commented 2 months ago

Okay - all good here. Happy to merge @valeriupredoi.