search

valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Improve help messages and interface for single job #40

Open ledm opened 2 years ago

ledm commented 2 years ago

This tool builds on the issues described in #37.

Still very much a draft, and is a lower priority than developments elsewhere, as the single job work is not used as much right now.

valeriupredoi commented 2 years ago

did you just make it a draft? I swear it was a RfR PR when I opened it - never mind, it's good to go as is if you wanna merge (see the few comments)

valeriupredoi commented 2 years ago

Still very much a draft, and is a lower priority than developments elsewhere, as the single job work is not used as much right now.

I actually just read the description :man_facepalming: :rofl:

ledm commented 2 years ago

Lol, thanks! This review will be useful, but I'm leaving this on the backburner until #39 is a bit better.

ledm commented 2 years ago

This also will make several changes to bgcval.py, which is currently broken after PR #41. That code (previously theWholePackage.py) runs several single job analyses, but we're focusing on the multi-job work right now. This means that we're going to fail some tests for a little while.

valeriupredoi commented 2 years ago

This also will make several changes to bgcval.py, which is currently broken after PR #41. That code (previously theWholePackage.py) runs several single job analyses, but we're focusing on the multi-job work right now. This means that we're going to fail some tests for a little while.

cool! I got us a branch to fix tests as soon as this gets in - actually that's gonna be a bit more of a general fix tests branch, where I'll add moar testing too