search

valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Mission atlantic dev #86

Closed ledm closed 1 year ago

ledm commented 1 year ago

Several new updates for Mission Atlantic, edit:

valeriupredoi commented 1 year ago

BTW where are you defining the strictFileCheck() method - I see the flag/kwarg but I can't find the method?

ledm commented 1 year ago

BTW where are you defining the strictFileCheck() method - I see the flag/kwarg but I can't find the method?

It's not a method, it's a boolean.

valeriupredoi commented 1 year ago

BTW where are you defining the strictFileCheck() method - I see the flag/kwarg but I can't find the method?

It's not a method, it's a boolean.

so how does it get set then?

ledm commented 1 year ago

Lol, your polish broke the tests...

ledm commented 1 year ago

So we're good to go here?

valeriupredoi commented 1 year ago

Lol, your polish broke the tests...

yeah I need to learn to indent :laughing:

So we're good to go here?

LGTM bud :beer:

valeriupredoi commented 1 year ago

lol I think I made a commit a few milliseconds right before you merged - we might qualify for the fastest commit before merge prize :rofl: