feat(path-resolvers): major rework of path resolution and executable settings

valeryan / vscode-phpsab

Php Sniffer and Beautifier for VS Code

https://marketplace.visualstudio.com/items?itemName=ValeryanM.vscode-phpsab

MIT License

58 stars 12 forks source link

feat(path-resolvers): major rework of path resolution and executable settings #119

Closed valeryan closed 2 months ago

valeryan commented 8 months ago

Deprecates the excutablePathCS and excutablePathCBF and creates a cross-platform way to handle paths using Unix-style paths.

TODO: Adding unit test for resolvers

BREAKING CHANGE:

Deprecates executablePathCBF in favor of fixerExecutablePath
Deprecates executablePathCS in favor of snifferExecutablePath
Moves snifferShowSources under the per workspace settings
Changes behavior of path resolution and auto search behavior

jonathanbossenger commented 8 months ago

I will do my best to review this week.

jonathanbossenger commented 8 months ago

@valeryan I'm testing this out on my environment now, but I also want to use that test repository you shared at some point. For the life of my I can't find it, would you mind sharing it here again?

valeryan commented 8 months ago

@jonathanbossenger https://github.com/valeryan/multi-root-example I need to push an update to it later today (done) but this is my test bed for validating the extension. I feel like we might be able to integrate this at some point for use with an end-to-end test.

valeryan commented 2 months ago

@jonathanbossenger I going to merge this into the dev branch and so we cant start testing that branch heavily at some point.

jonathanbossenger commented 2 months ago

Thanks @valeryan

I've not opened VS Code since late June as I've been deep into planning new projects at work, but I should be able to start testing things out again from next week.