valeryan / vscode-phpsab

Php Sniffer and Beautifier for VS Code
https://marketplace.visualstudio.com/items?itemName=ValeryanM.vscode-phpsab
MIT License
58 stars 12 forks source link

No problems in the workspace? #147

Open Dekadinious opened 1 month ago

Dekadinious commented 1 month ago

I am coming from the wongj extension, and there the "Problems" tab in my workspace shows all failed sniffs that did not get automatically fixed. I am just realizing that this does not happen for this extension.

I was just wondering if I am missing something?

Dekadinious commented 1 month ago

I would add here that doing phpcs "filename" in the terminal will give errors:

FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
  99 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
 212 | ERROR   | Missing doc comment for function [function_name]
 228 | WARNING | print_r() found. Debug code should not normally be used in
     |         | production.
 239 | ERROR   | Empty IF statement detected
 252 | WARNING | print_r() found. Debug code should not normally be used in
     |         | production.
 269 | WARNING | print_r() found. Debug code should not normally be used in
     |         | production.
 345 | ERROR   | Missing doc comment for function [function_name]
--------------------------------------------------------------------------------

Time: 670ms; Memory: 14MB

But none of these are shown under the "problems" tab. Only fatal syntax errors are shown, but it's unclear if they come from this extension or from VSCode itself. Where should I expect to see the errors and warnings from the extension? :)

calebsmithdev commented 1 month ago

I went back to version 0.0.17 and everything is working now. 0.0.18 did not work either.

cstielper commented 1 week ago

Same issue for me, although version 18 worked fine.

phpcbf

Running "PHPCBF: Fix this file" from the command palette fixes the errors if they exist, they're just not displayed.