valgur / velodyne_decoder

Fully-featured C++/Python Velodyne packet decoder
BSD 3-Clause "New" or "Revised" License
39 stars 12 forks source link

insert reading of rosbag from ROS1 while system ROS is ROS2 #6

Open flopie2009 opened 1 year ago

flopie2009 commented 1 year ago

This PR inserts the functionality to use the rosbags package which is independent from the system ROS version. Resulting you can read ROS1 rosbags even if your system version is ROS2.

flopie2009 commented 1 year ago

Hi @valgur , I created this PR to enable the usage of the rosbags python package to be independent of the system ROS version. Can you maybe have a look on it? Additionally if it can be merged, it would be good if you can generate a new version of the corresponding python package. Thank you for your support.

valgur commented 1 year ago

Thank you @flopie2009! I will try to merge these changes into the next release. Possibly not in this exact form, but adding support for rosbags and ROS 2 is in the plans.