Added nvm and node v8 - Githubissues

valhalla / docker

docker

MIT License

17 stars 22 forks source link

Closed oxidase closed 6 years ago

oxidase commented 6 years ago

PR https://github.com/valhalla/valhalla/pull/1341 requires node v8 to run npm install and potentially node bindings test cases.

PR adds nvm and node lts/carbon to the build image.

The image is not yet tested, so can be merged with an ack from @allierowan

/cc @kevinkreiser

allierowan commented 6 years ago

@oxidase do we also install npm here, or do I do that in the circle file?

oxidase commented 6 years ago

@allierowan both node and npm will be installed in the image