search

valhalla / homebrew-valhalla

Install the Valhalla routing engine on Mac OS using the Homebrew package manager
MIT License
8 stars 4 forks source link

Minor issues #4

Closed adius closed 6 years ago

adius commented 6 years ago

Hi,

there were some typos and bugs in your code. I took the liberty to fix them for you. 😉

Well, actually, Feram did it. It’s a tool that we developed to fix our own code. If you want to use it as well, it’s really simple to integrate: feram.io/help/getting-started

Hope you like it! 😁

DomT4 commented 6 years ago

This technically adheres to Ruby standards but doesn't adhere to Homebrew's, which follows the Rubocop style guide with some customisations, FWIW.

adius commented 6 years ago

The args and the :tags simplifactions look definitely useful!?

DomT4 commented 6 years ago

You're welcome to discuss it with the person who maintains this tap, I have absolutely no power here. Just saying the changes don't adhere to Homebrew standard, as you can see yourself from the ~4500 examples here.

drewda commented 6 years ago

Thank you for your contribution, @adius.

Personally, I prefer the contemporary Ruby style of single quotes when not using string interpolation, leaving hashrockets in the past, etc.

But in the context of this repo -- a Homebrew formula -- let's stick with the style enforced by brew audit --strict https://raw.githubusercontent.com/valhalla/homebrew-valhalla/master/Formula/valhalla.rb.

If you'd like to propose any functionality changes, please do open a PR at any time!