search

valhalla / valhalla

Open Source Routing Engine for OpenStreetMap
https://valhalla.github.io/valhalla/
Other
4.56k stars 688 forks source link

Directions Request is returning an incorrect start location and sometimes end. #1016

Open farough opened 7 years ago

farough commented 7 years ago

Hi,

So I've been implementing Mapzen Directions in our application and we've come across an unusual issue. Sometimes when we request directions in some places we get back directions that actually don't start at the correct start location.

In this example query, it is happening 100% of the time for the start location. https://valhalla.mapzen.com/route?api_key=<AN_API_KEY>&json={"costing_options":{"use_roads":0.5,"bicycle_type":"City","use_hills":0.5,"use_ferry":0.5},"locations":[{"minimum_reachability":50,"lat":49.079206,"heading_tolerance":60,"lon":6.103717,"heading":0,"radius":0},{"minimum_reachability":50,"lat":49.07661938310676,"heading_tolerance":60,"lon":6.101630553603172,"radius":0}],"directions_options":{"units":"kilometers","language":"en_us"},"costing":"bicycle"}

The response I'm seeing is starting the trip at Latitude: 49.0946 and Longitude: 6.119307. Ending the trip at Latitude: 49.076625 and Longitude: 6.101662.

In this case, the end location is sufficiently close, but as you can see the start location of Latitude: 49.079206 and Longitude: 6.103717 are quite a bit different. Here they are 2km apart. Obviously, we can't do much with this kind of response being very unrelated to the query.

I've noted that removing the heading seems to give a proper response, so I suspect this is the cause of the issue.

I don't have an example of the destination changing right now but I will try to find one and post it on this or another issue. I think the two are probably related though, so that's why I'm mentioning it in the same place.

Let me know if we need any more information.

dnesbitt61 commented 7 years ago

It could be do to this gate: http://www.openstreetmap.org/edit#map=19/49.09453/6.11963 ? Nothing is allowed to proceed past this gate so it could be that when you specify the heading it does not match a path going in the opposing direction.

farough commented 7 years ago

Ok, but my start location is actually over here. http://www.openstreetmap.org/edit#map=17/49.07890/6.10401

This is my problem.

farough commented 7 years ago

Here is an example of the same issue, but both start and end location are not the locations specified. https://valhalla.mapzen.com/route?api_key=&json={"costing_options":{"use_roads":0.5,"bicycle_type":"City","use_hills":0.5,"use_ferry":0.5},"locations":[{"minimum_reachability":50,"lat":49.07911408826564,"heading_tolerance":60,"lon":6.103531843314007,"heading":228,"radius":0},{"minimum_reachability":50,"lat":49.07661938310676,"heading_tolerance":60,"lon":6.101630553603172,"radius":0}],"directions_options":{"units":"kilometers","language":"en_us"},"costing":"bicycle"}

The response gives only one location for the entire polyline. The second location is a difference of 0 from the first. [[6.119307, 49.0946], [6.119307, 49.0946]]

Neither of which is the start or end location of the original request.

Again, if I remove the heading from the query, it works as expected.

kevinkreiser commented 7 years ago

I'll take a look at the heading code to see if something is wrong there, thanks!