valheimPlus / ValheimPlus

A HarmonyX Mod aimed at improving the gameplay and quality of life of the game Valheim.
http://valheim.plus
GNU Affero General Public License v3.0
967 stars 236 forks source link

[BUG] Map pins not shared amongst players on the server #732

Open lennyxc opened 1 year ago

lennyxc commented 1 year ago

Describe the bug

Map pins do not seem to be shared amongst the players on the server

To Reproduce

  1. Join dedicated server
  2. Player A sets some pins on map
  3. Player B sets some pins on map
  4. Player A cannot see B's pins, and vice versa.

Expected behavior

Shared map pins visible on the map for all players.

Troubleshooting

What steps have you taken to try to fix?

N/A

Screenshots

N/A

Config

; Change false to true to enable this section. https://valheim.plus/documentation/list#Map enabled = true

; With this enabled you will receive the same exploration progression as other players on the server. ; This will also enable the option for the server to sync everyones exploration progression on connecting to the server. shareMapProgression = true

; The radius of the map that you explore when moving. exploreRadius = 100

; Prevents you and other people on the server to turn off their map sharing option. preventPlayerFromTurningOffPublicPosition = true

; This option automatically shares created pins with everyone playing on the server. shareAllPins = true

; Display carts and boats on the map displayCartsAndBoats = true

Additional context

Please list any other mods besides V+ that you have installed here. Add any other context about the problem here.

No other mods installed

andres-valdes commented 1 year ago

Yep. There also used to be a UI that popped up for making pins, doesn't show up either.

snips86x commented 1 year ago

Map pins were retired use the cartography table.

andres-valdes commented 1 year ago

Were they actually? The mod's implementation is infinitely better than the cartography table.

snips86x commented 1 year ago

Yeah, it's been the case since 9.9.7 or 9.9.8.

SerpentDrago commented 1 year ago

from my understanding the Pop up ui for making pins was retired , not the sharing of the pins / syncing them between players .

other wise why would it be in the config file as a option ?

SSimp258 commented 1 year ago

from my understanding the Pop up ui for making pins was retired , not the sharing of the pins / syncing them between players .

other wise why would it be in the config file as a option ?

Unfortunately, when you take away the GUI to add a pin, you also take away the part that shares the pin. That whole section of code was retired. From what I took away was NX was gonna come back to it, but the cartography table does almost the exact same thing.

It's been in the CFG because it's just never been removed from that section just in case NX does come back to it. The coding in V+ also hasn't been removed, it's just disabled because the GUI needed a rework to make it simple.

Right now, the "workaround," as some have called it, is to use the cartography table until when/if this feature makes a comeback.

SerpentDrago commented 1 year ago

yeh problem with the table is its not instant . we like using markers while out and about . to make easy markers for reference .

andres-valdes commented 1 year ago

from my understanding the Pop up ui for making pins was retired , not the sharing of the pins / syncing them between players . other wise why would it be in the config file as a option ?

Unfortunately, when you take away the GUI to add a pin, you also take away the part that shares the pin. That whole section of code was retired. From what I took away was NX was gonna come back to it, but the cartography table does almost the exact same thing.

It's been in the CFG because it's just never been removed from that section just in case NX does come back to it. The coding in V+ also hasn't been removed, it's just disabled because the GUI needed a rework to make it simple.

Right now, the "workaround," as some have called it, is to use the cartography table until when/if this feature makes a comeback.

Do you have the issue/PR where this was discussed? I'd love to see the discussion and possibly contribute a fix.

pdickey commented 1 year ago

672 is probably the best place for it before SSimp258 derailed the thread by repeatedly saying that the feature was not coming back and to just use the cartography table instead.

I submitted the issue pretty quickly after the change went live, so you can use the date and version info to start digging in.

LetoDK commented 1 year ago

Yup, SSimp258 has a weird "chip on his shoulder" about this topic, which makes him spread the misinformation that the feature "has been retired", when the developers have explicitly stated on multiple occasions that the feature is not retired, but simply currently broken.

@pdickey I would like to kindly remind you that it's probably a good idea to reopen your issue report at some point, as it's currently set to "closed".

SSimp258 commented 1 year ago

Yup, SSimp258 has a weird "chip on his shoulder" about this topic, which makes him spread the misinformation that the feature "has been retired", when the developers have explicitly stated on multiple occasions that the feature is not retired, but simply currently broken.

Not a chip if this is the information I've been told by Devs and by other Chat moderators on the discord. You guys have had another chat mod come in here and confirm it so i'm asking you guys to cease and desist the incorrect messages you are posting. If you don't, I will ask NX to block you from this GIT.

If you decide to reopen the issue, that's fine but it's not high on the fix list unless someone else wants to try to fix it. That's the other thing NX has said and that's why it was retired. See my other messages above if you guys want to fix it yourself. I gave you a roadmap and a starting point in a previous message.

pdickey commented 1 year ago

@pdickey I would like to kindly remind you that it's probably a good idea to reopen your issue report at some point, as it's currently set to "closed".

Sure. #672 has more history so I'll reopen it, but that means that this issue is a duplicate.

LetoDK commented 1 year ago

@pdickey Great stuff👍 I believe the devs can merge the two issue reports if they need to.