valheimPlus / ValheimPlus

A HarmonyX Mod aimed at improving the gameplay and quality of life of the game Valheim.
http://valheim.plus
GNU Affero General Public License v3.0
967 stars 236 forks source link

[BUG] Incompatible Version when `valheim_plus.cfg` created before launching V+ server #767

Open frantjc opened 1 year ago

frantjc commented 1 year ago

Describe the bug

If V+ server is started for the first time with valheim_plus.cfg already in place, it starts up thinking its a different version, causing an Incompatible Version error when connecting from the client.

Get Incompatible Version after connecting and entering password.

Relevant, cleansed server-side BepInEx/LogOutput.log:

[Info   : Unity Log] 01/19/2023 21:16:28: New connection
[Info   : Unity Log] 01/19/2023 21:16:28: Accepting connection k_EResultOK
[Info   : Unity Log] 01/19/2023 21:16:28: Connecting to Steamworks.SteamNetworkingIdentity
[Info   : Unity Log] 01/19/2023 21:16:28: Got status changed msg k_ESteamNetworkingConnectionState_Connected
[Info   : Unity Log] 01/19/2023 21:16:28: Connected
[Info   : Unity Log] 01/19/2023 21:16:28: Got connection SteamID 123
[Info   : Unity Log] 01/19/2023 21:16:28: Got handshake from client 123
[Info   : Unity Log] 01/19/2023 21:16:33: VERSION check their:0.212.9@0.9.9.11  mine:0.212.9
[Info   : Unity Log] 01/19/2023 21:16:33: Peer 76561198296433998 has incompatible version, mine:0.212.9 remote 0.212.9@0.9.9.11
[Info   : Unity Log] 01/19/2023 21:16:34: RPC_Disconnect 
[Info   : Unity Log] 01/19/2023 21:16:34: Disposing socket
[Info   : Unity Log] 01/19/2023 21:16:34: Closing socket 123
[Info   : Unity Log] 01/19/2023 21:16:34:   send queue size:0
[Info   : Unity Log] 01/19/2023 21:16:34: Disposing socket
[Info   : Unity Log] 01/19/2023 21:16:34: Got status changed msg k_ESteamNetworkingConnectionState_ClosedByPeer
[Info   : Unity Log] 01/19/2023 21:16:34: Socket closed by peer Steamworks.SteamNetConnectionStatusChangedCallback_t
[Info   : Unity Log] 01/19/2023 21:16:34: Got status changed msg k_ESteamNetworkingConnectionState_None

Note the versions are the same aside from the stuff after the @

Expected behavior

No version mismatch.

Troubleshooting

Removing valheim_plus.cfg before launching the V+ server initially resolves the error.

Additional context

No additional mods/plugins.

frantjc commented 1 year ago

I discovered that it depends on if I place the valheim_plus.cfg before I start the server the first time rather than letting the server generate it first and then editing it.

Updating primary post to match

EnkiTWS commented 1 year ago

I discovered that it depends on if I place the valheim_plus.cfg before I start the server the first time rather than letting the server generate it first and then editing it.

Updating primary post to match

So it has to have been created BEFORE the update? or it doesn't work? It explains why when I rolled V+ back several version it did the same thing. Verified the manifests and everything

frantjc commented 1 year ago

I discovered that it depends on if I place the valheim_plus.cfg before I start the server the first time rather than letting the server generate it first and then editing it. Updating primary post to match

So it has to have been created BEFORE the update? or it doesn't work? It explains why when I rolled V+ back several version it did the same thing. Verified the manifests and everything

I can't speak for updating; I have only tested on the very first run as I tear everything down and bring it back up with each change.

what I do know is that you should not create valheim_plus.cfg; you should let V+ create it and then edit it to your liking.

EnkiTWS commented 1 year ago

I tried that too with a brand new install new config file with no changes, just straight up with no other mods and still experienced with the exact same issue.

On Fri, Feb 3, 2023, 7:04 AM Alex Logsdon @.***> wrote:

I discovered that it depends on if I place the valheim_plus.cfg before I start the server the first time rather than letting the server generate it first and then editing it. Updating primary post to match

So it has to have been created BEFORE the update? or it doesn't work? It explains why when I rolled V+ back several version it did the same thing. Verified the manifests and everything

I can't speak for updating; I have only tested on the very first run as I tear everything down and bring it back up with each change.

what I do know is that you should not create valheim_plus.cfg; you should let V+ create it and then edit it to your liking.

— Reply to this email directly, view it on GitHub https://github.com/valheimPlus/ValheimPlus/issues/767#issuecomment-1415996724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCXWD64WE4GLSAEN7WGJILWVUM6FANCNFSM6AAAAAAUA2P5UE . You are receiving this because you commented.Message ID: @.***>