valheimPlus / ValheimPlus

A HarmonyX Mod aimed at improving the gameplay and quality of life of the game Valheim.
http://valheim.plus
GNU Affero General Public License v3.0
967 stars 236 forks source link

[FEATURE REQUEST] Include ValheimPlus in version string #779

Open MSchmoecker opened 1 year ago

MSchmoecker commented 1 year ago

Is your feature request related to a problem? If so, please describe. ValheimPlus changes the version string to enforce it on all clients, for example 0.212.9 is changed to 0.212.9@0.9.9.11. It is not always clear for new players which mod is doing this and need time to figure this out.

Describe the solution you'd like The attached string should be changed to include the mod name, so something like 0.212.9-ValheimPlus@0.9.9.11. Since the version string is changed with each V+ version anyway and there is no parsing involved as far as I'm aware, this should be a non-breaking, minor change that helps new players understanding why they can't connect to a server.

SSimp258 commented 1 year ago

So typically, I don't tell a new player or someone new to modding to dig into the log file like you're describing. I normally have them check for the V+ splash on the main menu and then have them check the lower right corner of their game for their version numbers like in the pic. This is the easiest way for a new player or someone new to modding to check their version number. If i suspect something is wrong in the log file, I have that person post the log to the discord so i can read through it since 95% of people don't know how to read the log. It's just easier this way.

image

MSchmoecker commented 1 year ago

Well, the V+ tag doesn't work on a headless server so you can't compare versions there.

If this would be a breaking or big change for V+ I would agree with your point. Log files are more inaccessible then a UI for new players. But since it doesn't change anything in the version check itself but only clarifies it, I don't see why it shouldn't be done.

OrianaVenture commented 1 year ago

Having a more clear change for the version string would help other communities a lot. Other mod makers don't always know that the version string is being changed by V+, especially new people. The current way is very confusing, even more so for users trying to debug their mod issues with the log files.

MSchmoecker commented 1 year ago

To add, the version string can also be shown in vanilla UI since a few Valheim versions when trying to join a server where V+ is not installed. This makes the change even more useful.

image

kiloforce commented 1 year ago

+1

SSimp258 commented 1 year ago

@kiloforce Please do not comment "+1" on posts. It's not needed.