search

valhrd / pe

0 stars 0 forks source link

Phone number does not accept '+' symbol #4

Open valhrd opened 1 week ago

valhrd commented 1 week ago

Prerequisites: None

Command to execute: addp n/John Doe p/+1 54 98765428 e/johnd@example.com a/311, Clementi Ave 2, #02-25 r/organiser t/friends t/owesMoney

Result: image.png The command is unable to executed in the CLI and the error shown is returned. The User Guide does not specify that the users are all Singaporean or always have a Singaporean number, so there is chance for someone using a foreign number needing to add their contact but unable to specify details like country or even state code.

Suggestion: Adjust the regex used to validate phone numbers to accept '+' and other necessary characters to accommodate such users.

nus-pe-bot commented 1 week ago

Your response not required for this bug as the team has accepted the bug as it is.