valiantwarrior / juggernaut-method-basic

Android App of Juggernat Basic Method base template spreadsheet
1 stars 0 forks source link

#10 Consume too much memory (probably related with session mapper logic & session load logic -> Too many uneccessary Routine objects are being created) #10

Closed valiantwarrior closed 2 years ago

valiantwarrior commented 2 years ago

Related

https://github.com/valiantwarrior/juggernaut-method-basic/blob/a794896868754ab7e5aac8d4098aa180785db945/android/app/src/main/java/kr/valor/juggernaut/ui/session/preview/PreviewViewModel.kt#L20

Screenshot_20220403-025418_Settings

Compare with YouTube

Screenshot_20220403-025025_Settings

valiantwarrior commented 2 years ago

Optimazation - Common (Routine object가 필요 이상으로 많이 생성됨)

Repository에서 Session을 가져오는 방식을 개선해야 할 필요가 있음

Optimizeation 1 - Home(Overview, Detail), Overall

overview

Overview 관련 : AMRAP, Phase-MicroCycle 관련 정보만 표시하면 충분하기 때문에 굳이 이 포인트에서 완전한 Session 모델로 매핑해서 가져올 필요갸 없음. ( Summary 정보만 띄워주는 mapper 혹은 extension 정도면 충분할 듯)

Detail 관련 : Overview와 동일한 맥락

Overall 관련 : Overview와 동일한 맥락

Optimization 2 - Preview

preview

Optimaization - Common

Optimization 3 - Record

record

Optimaization - Common