#2 MainActivity being created twice - Githubissues

valiantwarrior / juggernaut-method-basic

Android App of Juggernat Basic Method base template spreadsheet

1 stars 0 forks source link

#2 MainActivity being created twice #2

Closed valiantwarrior closed 2 years ago

valiantwarrior commented 2 years ago

ecf07126e1cbdf2790976f8259890ff515c0cab6

LauncherViewModel.kt

https://github.com/valiantwarrior/juggernaut-method-basic/blob/ecf07126e1cbdf2790976f8259890ff515c0cab6/android/app/src/main/java/kr/valor/juggernaut/ui/LauncherViewModel.kt#L21-L29

LauncherActivity.kt

https://github.com/valiantwarrior/juggernaut-method-basic/blob/ecf07126e1cbdf2790976f8259890ff515c0cab6/android/app/src/main/java/kr/valor/juggernaut/ui/LauncherActivity.kt#L20-L38

FlowEventObserver.kt

https://github.com/valiantwarrior/juggernaut-method-basic/blob/ecf07126e1cbdf2790976f8259890ff515c0cab6/android/app/src/main/java/kr/valor/juggernaut/ui/FlowEventObserver.kt#L20-L26

valiantwarrior commented 2 years ago

LauncherActivity.kt (ecf07126e1cbdf2790976f8259890ff515c0cab6)

https://github.com/valiantwarrior/juggernaut-method-basic/blob/ecf07126e1cbdf2790976f8259890ff515c0cab6/android/app/src/main/java/kr/valor/juggernaut/ui/LauncherActivity.kt#L20-L38

Main이나 Onboarding 상태에 진입했을때에만 finish()를 호출해야하나, when 밖에서 finish() 호출

LauncherActivity.kt (49553220893ae818462426f7fa698a9b6b88b7ae)

https://github.com/valiantwarrior/juggernaut-method-basic/blob/49553220893ae818462426f7fa698a9b6b88b7ae/android/app/src/main/java/kr/valor/juggernaut/ui/LauncherActivity.kt#L20-L30

LauncherViewModel.kt (49553220893ae818462426f7fa698a9b6b88b7ae)

https://github.com/valiantwarrior/juggernaut-method-basic/blob/49553220893ae818462426f7fa698a9b6b88b7ae/android/app/src/main/java/kr/valor/juggernaut/ui/LauncherViewModel.kt#L22-L37

state를 캐싱할 필요가 없기 때문에, ViewModel에서 statIn 삭제
마찬가지로, 초기값이 필요없기 때문에 Loading 삭제
theme, destination를 activity에서 동시에 consume 해야하기 때문에 ViewModel의 init 에서 dataStore의 값을 직접 가져옴 (.fist())