valida-xyz / valida

A STARK-based VM focused on code reuse, performance, and modularity
Apache License 2.0
270 stars 47 forks source link

Update ISA spec #106

Open thealmarty opened 7 months ago

thealmarty commented 7 months ago

Our ISA spec is getting out of date as we actively develop. We should update it. E.g.,

morganthomas commented 7 months ago

@maxgillett is making a start on this. That said, I would caution us against premature documentation. Most of these opcodes are experimental and it's not clear that they will be included in a release. We can avoid unnecessary documentation effort and producing docs that will be quickly out of date by waiting until APIs stabilize before we document them.

thealmarty commented 7 months ago

Awesome start with https://github.com/valida-xyz/valida/pull/60, thanks! Yes we can fill out the doc more later but I'd like to keep track of it as we go as well.

thealmarty commented 6 months ago

As per #113 the spec for READ_ADVICE has been updated to:

Operands: a Description: Read the content of the advice tape and write the next byte to the low byte of the word beginning at offset a. If the end of the advice tape is reached, write 0xFFFFFFFF instead.

thealmarty commented 6 months ago

As per #108 LOADFP is implemented.but not tested.