Fixed access_key and secret_key

[lpanza]

The issue is that in the "thanos-object-storage" secret, in the the "thanos.yaml" key the "access_key" and "secret_key" value were encoded, while they need to be decoded in order to be used Also, fixed the issue with TLS, as with "insecure: ture" thanos tries to connect via http, while to disable the tls verification we need to edit the "http_config" key

[ipbabble]

@day0hero LGTM. Any concerns?

[ipbabble]

I am seeing errors deploying this. ODF is not coming up and therefore Quay and observability policy.

I think the issue is the channel is pointing to 4.12 and I deployed on 4.11... sigh.

@lpanza Can you change ODF channel to 4.11 - we don't yet support 4.12 (did you get that to work? I assume so since you PRed)

I'm testing with 4.11 now. I'll let you know how it goes.

William

[ipbabble]

When I fixed things to 4.11 it looked better but I think the failed first attempt left some issues. I'd like to retest this with 4.11. Doubt I'll get to it this week.

[lpanza]

I brought up a 4.11 cluster (4.11.26) and I got some errors during the first run, but after cleaning everything up it worked as expected, I assume that not all of the components were running in the proper way. I am going to tear down the cluster and bring it up again, wait some time and rerun the pattern.

Bear in mind that I am running the pattern.sh script from this branch where the fix that I made is just for the Thanos part, all of the other components such as channels and storage classes are the same as in the main branch.

I will let you know ASAP.

[lpanza]

I have done what I anticipated in the previous comment and I confirm that on 4.11.26 the patthern.sh make install command works without any change to make, so it is running ODF 4.10 and using the gp2 storage class.

[lpanza]

Hello @ipbabble @day0hero , any update on this topic?

[ipbabble]

I'm looking at this now on 4.12.

[lpanza]

Hello @ipbabble, have you had the chance to check the changes?

[ipbabble]

Besides the unexpected dragging in of some "tests" artifacts from Industrial Edge pattern. This LGTM. I don't think that this is your problem @lpanza . We can clean up the tests.

@mbaldessari merge?

[ipbabble]

Actually wait! This looks like you've tried to make changes to the other patterns in this patterns repo. Is that right? The tests files for medical diagnosis and industrial edge are in here. They need to be removed before the commit.

[lpanza]

I changed the charts/hub/opp/templates/policy-ocm-observability.yaml file and all of the others stated under tests/* were changed by the pattern.sh make tests command. Do I need to do something in order to clean up the PR?

[mbaldessari]

This is fine, thanks @lpanza