search

validatedpatterns / multicluster-devsecops

Apache License 2.0
20 stars 66 forks source link

Made the clusterGroup.imperative map empty by default #79

Closed lpanza closed 1 year ago

lpanza commented 1 year ago

I started to look into the Pattern in 4.12 and the multicluster-devsecops-hub application in the default OpenShift GitOps Project was not working properly. Looking at the value file, I saw that the key holds hashes and after putting the opening-closing brace everything started to work again as intended.

I assume that if one wants to edit or add some values he needs to add them to the values-*-hub.yaml, right?

mbaldessari commented 1 year ago

Thanks @lpanza ! So adding ./values-AWS-4.12.yaml should not be needed as ./values-AWS.yaml has the same content. Is there a special reason you wanted to add it?

The empty imperative map is prolly a bug in common/, but let's fix it by adding an empty hash like you did. Could you drop the ./values-AWS-4.12.yaml from this PR, so merge the imperative fix/workaround?

lpanza commented 1 year ago

Not really! I just removed it from the PR so that only the empty hash is in place. Thank you very much!

mbaldessari commented 1 year ago

Thanks again @lpanza