search

validatedpatterns / regional-resiliency-pattern

Apache License 2.0
3 stars 4 forks source link

Wanted change in common? #5

Closed mbaldessari closed 6 days ago

mbaldessari commented 1 week ago

Hi @TomerFi @r2dedios , I was trying to update common in this pattern and I noticed this difference:

  cloud: {{ $cloud }}
    region: '{{ $region }}'
    vendor: OpenShift
-    cluster.open-cluster-management.io/clusterset: {{ .name }}
+    cluster.open-cluster-management.io/clusterset: {{ $group.name }}
spec:
  {{- if .size }}

Do we need a change like this in proper common, or can we drop this ? Thanks, Michele

TomerFi commented 1 week ago

Hi @mbaldessari This look familliar! What file is this in?

TomerFi commented 1 week ago

If I remember correctly, the same context also has a $group = . somewhere. So, there's a chance this was done for consistency.

mbaldessari commented 1 week ago

Hi @TomerFi , apologies I missed to copy the file name. It is https://github.com/validatedpatterns/regional-resiliency-pattern/blob/main/common/acm/templates/provision/clusterpool.yaml#L47. I'll push a change to use $group.name in proper common and put you in CC. From a quick look it does look sane