search

validator-labs / validator-plugin-network

validator-plugin-network validates your network and creates ValidationResults for validator to consume.
https://validator-labs.github.io/docs
Apache License 2.0
3 stars 0 forks source link

refactor: make each rule implement `validationrule.Interface` #258

Closed mattwelke closed 3 months ago

mattwelke commented 3 months ago

Description

Makes each rule in the plugin implement validationrule.Interface from validator@v0.1.7.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Files Patch % Lines
api/v1alpha1/networkvalidator_types.go 0.00% 12 Missing :warning:
pkg/network/network.go 0.00% 5 Missing :warning:
internal/controller/networkvalidator_controller.go 0.00% 1 Missing :warning: 
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   39.94%   38.73%   -1.22%     
==========================================
  Files           7        7              
  Lines         383      395      +12     
==========================================
  Hits          153      153              
- Misses        216      228      +12     
  Partials       14       14
Files Coverage Δ
internal/controller/networkvalidator_controller.go 46.00% <0.00%> (ø)
pkg/network/network.go 23.40% <0.00%> (ø)
api/v1alpha1/networkvalidator_types.go 60.00% <0.00%> (-21.82%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cb12a2...c9fe030. Read the comment docs.