Open TylerGillson opened 3 months ago
Hi @TylerGillson, I would be willing to work on this issue.
Hey @ADorigi. That would be fantastic! Contributions are very welcome. Let me know if you have any questions about how to get started. This epic requires a PR for all official plugins.
Thank you @TylerGillson
I will be starting with the validator-plugin-oci
plugin and working towards the other plugins.
After addition of the annotation, a simple resource definition of kind OciValidator
would look like:
apiVersion: validation.spectrocloud.labs/v1alpha1
kind: OciValidator
metadata:
name: ocivalidator-sample-public-oci-registries
namespace: validator
annotations:
reconciliation-frequency: "120"
spec:
ociRegistryRules:
- name: "public oci registry with tag"
host: "docker.io"
validationType: "none"
artifacts:
- ref: "library/redis:7.2.4"
I have taken the following points into consideration:
reconciliation-frequency
. Let me know if there should be a specific DNS subdomain as the prefix for the key. I will be working towards implementing the above. Please advise if the approach needs to be modified.
Please use validation.validator.labs/reconciliation-frequency
for the annotation. It is good practice to prefix annotations with the API group of the associated resource to avoid naming conflicts across the ecosystem. Thanks for verifying that.
Your approach looks good!
Hello @TylerGillson
I have created a pull request for validator-plugin-oci
at validator-labs/validator-plugin-oci#297.
Hello @TylerGillson I have created the PR at #422 with the suggested changes. Please have a look.
Summary
Today, all validator plugin custom resources are re-reconciled every 2m. This value should be configurable.