search

validator-labs / validator

validator monitors ValidationResults created by one or more validator plugins and uploads them to a configurable sink.
https://validator-labs.github.io/docs
Apache License 2.0
17 stars 3 forks source link

feat: finalization helper for ValidationRuleResults #415

Closed TylerGillson closed 2 months ago

TylerGillson commented 2 months ago

Issue

N/A

Description

Add finalization helper for ValidationRuleResults. It must be called in Validate for all plugins to ensure proper error handling in direct mode.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/helm/helm.go 0.00% 0 Missing and 2 partials :warning: 
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   53.43%   54.30%   +0.87%     
==========================================
  Files          22       22              
  Lines        1136     1138       +2     
==========================================
+ Hits          607      618      +11     
+ Misses        460      453       -7     
+ Partials       69       67       -2
Files with missing lines Coverage Δ
pkg/test/util.go 0.00% <ø> (ø)
pkg/types/types.go 66.66% <100.00%> (+66.66%) :arrow_up:
pkg/validationresult/validation_result.go 72.54% <100.00%> (-1.04%) :arrow_down:
pkg/helm/helm.go 40.81% <0.00%> (ø)

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 288194c...2fc7268. Read the comment docs.