feat: frequency annotation helper

validator-labs / validator

validator monitors ValidationResults created by one or more validator plugins and uploads them to a configurable sink.

https://validator-labs.github.io/docs

Apache License 2.0

17 stars 3 forks source link

feat: frequency annotation helper #422

Closed ADorigi closed 1 month ago

ADorigi commented 1 month ago

Issue

partially resolves https://github.com/validator-labs/validator/issues/358

Description

A constant was added to define the annotation key validation.validator.labs/reconciliation-frequency.
Function FrequencyFromAnnotations which accepts annotation map and returns ctrl.Result.
Tests for FrequencyFromAnnotations function.

TylerGillson commented 1 month ago

@ADorigi apologies for the delay - I was on PTO. Two small nits regarding logging, otherwise the changes look good!

ADorigi commented 1 month ago

No worries @TylerGillson
I have updated the logs to reflect the changes.

TylerGillson commented 1 month ago

@ADorigi thanks for making those changes. We just need a make reviewable and it'll be good to go!

ADorigi commented 1 month ago

@TylerGillson Running make reviewable made a few changes in chart/validator/values.yaml and chart/validator/README.md, which may not be as expected. Let me know if these need to be reverted.

TylerGillson commented 1 month ago

@ADorigi you needed to do a git submodule update --remote then make reviewable. I did it for you though, so no worries this time.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   54.46%   55.01%   +0.54%     
==========================================
  Files          23       24       +1     
  Lines        1153     1167      +14     
==========================================
+ Hits          628      642      +14     
  Misses        457      457              
  Partials       68       68

Files with missing lines	Coverage Δ
pkg/plugins/plugin_frequency.go	`100.00% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 735df90...89e8b5a. Read the comment docs.