search

validator / htmlparser

The Validator.nu HTML parser https://about.validator.nu/htmlparser/
Other
56 stars 26 forks source link

Mozilla bug 1701828 - Meta charset rewrite for Gecko. #57

Closed hsivonen closed 2 years ago

hsivonen commented 3 years ago

Differential Revision: https://phabricator.services.mozilla.com/D125808

hsivonen commented 3 years ago

r? @smaug----

hsivonen commented 3 years ago

The Java change here intentionally leaves the new methods private so that there's no commitment to the Java API until the corresponding larger change has been implemented in the Java-facing driver code.

hsivonen commented 3 years ago

r+ for the Tokenizer.java changes

Thanks!

In the latest force-push, I gave things better names, added docs, and added consistent behavior for processing instructions, although they are only used in Gecko XML View Source, which doesn't call these methods.

hsivonen commented 3 years ago

Added more documentation comments.

sideshowbarker commented 2 years ago

Going ahead and merging here, on the assumption that any review comments @smaug---- might have could be addressed in a follow-up commit.

smaug---- commented 2 years ago

@hsivonen might have added some more comments to the code in mozilla-central, not sure.

hsivonen commented 2 years ago

Thanks for merging. Yeah, I forget to push the last round of added comments. I opened a new PR for them.