Closed rubiin closed 1 year ago
@parasg1999 pick the undone validators from here
@rubiin Sure! Will do. Was working on improving the test template.
I think we should remove isMD5
, since isHash
can be used with md5
as the second argument.
Also we are not trying to make it backwards compatible.
I think we should remove
isMD5
, sinceisHash
can be used withmd5
as the second argument. Also we are not trying to make it backwards compatible.
sure. Also we need to import any bug fixes from validator.js after we have ported the lib
Hey, can I also work on this??
@RishabAgarwal sure.
@parasg1999 lets speed up things as only 14 extra validators are needed to complete the lib
Thanks @rubiin. I started working on isDivisibleBy. I was wonder if (1.2, 0.2) should return true or false? Validator for nodejs returns false but in actual it is divisible.
Thanks @rubiin. I started working on isDivisibleBy. I was wonder if (1.2, 0.2) should return true or false? Validator for nodejs returns false but in actual it is divisible.
@RishabAgarwal validator.js only works for integers, we can include the support for float as well, but we need to pay attention to the precision errors. What do you say @rubiin
I created a PR for isDivisibleBy. I think we can add that later on.
Hey, so should just add more validator to the master branch, the same PR #21 or create a new branch and a PR for every new validator??
@RishabAgarwal you can do either way
I'll take isURL if no is doing it.
sure
I'll take up isEmail if no one is doing it
Go ahead! @RishabAgarwal
@RishabAgarwal @parasg1999 lets work on documentation now
Yeah sure. How do you wanna distribute it @rubiin
@RishabAgarwal you can do any and as much you like. theres no restrictions
@rubiin I'll get on it. Can you also add a check box list to the document issue too. So we can keep track of all the validator whose documentation is done.
@RishabAgarwal I have added that.
This is used to track all the validators that has been ported successfully . Feel free to send in any PR which ports the validators which are not ticked below
Won't work on