validatorjs / validator-deno

Official Port of validatorjs to deno
MIT License
12 stars 6 forks source link

Track progress #3

Closed rubiin closed 1 year ago

rubiin commented 4 years ago

This is used to track all the validators that has been ported successfully . Feel free to send in any PR which ports the validators which are not ticked below


Won't work on

rubiin commented 4 years ago

@parasg1999 pick the undone validators from here

parasg1999 commented 4 years ago

@rubiin Sure! Will do. Was working on improving the test template.

parasg1999 commented 4 years ago

I think we should remove isMD5, since isHash can be used with md5 as the second argument. Also we are not trying to make it backwards compatible.

rubiin commented 4 years ago

I think we should remove isMD5, since isHash can be used with md5 as the second argument. Also we are not trying to make it backwards compatible.

sure. Also we need to import any bug fixes from validator.js after we have ported the lib

RishabAgarwal commented 4 years ago

Hey, can I also work on this??

rubiin commented 4 years ago

@RishabAgarwal sure.

rubiin commented 4 years ago

@parasg1999 lets speed up things as only 14 extra validators are needed to complete the lib

RishabAgarwal commented 4 years ago

Thanks @rubiin. I started working on isDivisibleBy. I was wonder if (1.2, 0.2) should return true or false? Validator for nodejs returns false but in actual it is divisible.

parasg1999 commented 4 years ago

Thanks @rubiin. I started working on isDivisibleBy. I was wonder if (1.2, 0.2) should return true or false? Validator for nodejs returns false but in actual it is divisible.

@RishabAgarwal validator.js only works for integers, we can include the support for float as well, but we need to pay attention to the precision errors. What do you say @rubiin

RishabAgarwal commented 4 years ago

I created a PR for isDivisibleBy. I think we can add that later on.

RishabAgarwal commented 4 years ago

Hey, so should just add more validator to the master branch, the same PR #21 or create a new branch and a PR for every new validator??

rubiin commented 4 years ago

@RishabAgarwal you can do either way

RishabAgarwal commented 4 years ago

I'll take isURL if no is doing it.

rubiin commented 4 years ago

sure

RishabAgarwal commented 4 years ago

I'll take up isEmail if no one is doing it

parasg1999 commented 4 years ago

Go ahead! @RishabAgarwal

rubiin commented 4 years ago

@RishabAgarwal @parasg1999 lets work on documentation now

RishabAgarwal commented 4 years ago

Yeah sure. How do you wanna distribute it @rubiin

rubiin commented 4 years ago

@RishabAgarwal you can do any and as much you like. theres no restrictions

RishabAgarwal commented 4 years ago

@rubiin I'll get on it. Can you also add a check box list to the document issue too. So we can keep track of all the validator whose documentation is done.

parasg1999 commented 4 years ago

@RishabAgarwal I have added that.