search

validatorjs / validator-deno

Official Port of validatorjs to deno
MIT License
12 stars 6 forks source link

isCreditCard refractoring #5

Closed parasg1999 closed 4 years ago

parasg1999 commented 4 years ago

@rubiin I think we should reconsider isCreditCard method and rename it to isPayCard since it is impossible to tell the card type using number without using any APIs which is out of the scope of this library.

rubiin commented 4 years ago

Lets keep it on a discussion

parasg1999 commented 4 years ago

In the validator.js repository, they have decided not to rename the method. So maybe we can close it for now to maintain consistency.

rubiin commented 4 years ago

sure. Closing it on the favor of the comment