search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.31k forks source link

Deno support? #1300

Closed rubiin closed 2 years ago

rubiin commented 4 years ago

As you already know, deno's first lts will be out in like couple of days. How about porting this lib for deno. I will be happy for porting

rubiin commented 4 years ago

@profnandaa @ezkemboi

ezkemboi commented 4 years ago

@rubiin I do agree with that suggestion.

rubiin commented 4 years ago

@ezkemboi i started working on this. Here is the repo https://github.com/rubiin/validator .

profnandaa commented 4 years ago

@rubiin -- this sounds good with me. If you don't mind, you can bring it on the validaorjs org, will check with @chriso

rubiin commented 4 years ago

@profnandaa sure

profnandaa commented 4 years ago

@rubiin -- I have made the fork - https://github.com/validatorjs/validator-deno

rubiin commented 4 years ago

@profnandaa i will start working on that then .

parasg1999 commented 4 years ago

@profnandaa @rubiin checkout https://github.com/parasg1999/deno-validator

It's not complete but I have been porting everything as per TypeScript standards, and have also made testing compatible with Deno and the current validator.js style. If found suitable, we could integrate the repositories.

rubiin commented 4 years ago

@parasg1999 sounds good to me, lets get on with it

parasg1999 commented 4 years ago

@rubiin How should we proceed?

rubiin commented 4 years ago

@parasg1999 you can clone https://github.com/validatorjs/validator-deno and then add all your source files in a branch. Then we can merge things

parasg1999 commented 4 years ago

@rubiin Sure! On it. I wanted to make some issues there, but I am unable to see the issues tab. Could you please enable that?

Edit: I have created a PR.

profnandaa commented 4 years ago

@parasg1999 -- sorry, issues now enabled. @rubiin -- I have made you admin of the repo, please proceed as you wish.

davidokwudili commented 4 years ago

Wow Wow Wow.

@parasg1999 i can't believe this. This was too close as i was about creating an issue in respect to Validator for Deno. Been working on it for some days too to support typescript.

Kindly check it out https://github.com/okwudav/deno-string-validator

@profnandaa

rubiin commented 4 years ago

@profnandaa sure

rubiin commented 4 years ago

@rubiin Sure! On it. I wanted to make some issues there, but I am unable to see the issues tab. Could you please enable that?

Edit: I have created a PR.

i will check that asap

rubiin commented 4 years ago

Wow Wow Wow.

@parasg1999 i can't believe this. This was too close as i was about creating an issue in respect to Validator for Deno. Been working on it for some days too to support typescript.

Kindly check it out https://github.com/okwudav/deno-string-validator

@profnandaa

you can send a PR for all the qork you have done on the https://github.com/validatorjs/validator-deno repo

profnandaa commented 4 years ago

I can close this now?

ooker777 commented 5 months ago

the deno lib has been archived 4 years ago. Why is that?