search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.31k forks source link

Contribute: Support for more locales to isTaxID #1423

Closed tplessas closed 3 years ago

tplessas commented 4 years ago

Hello everyone,

I would like to add support for EU member state & UK tax identification numbers to isTaxID based on this document: https://ec.europa.eu/taxation_customs/tin/specs/FS-TIN%20Algorithms-Public.docx

I see that PR #1409 has already paved the way, so I could fork and work from there once it's merged. Please let me know if that would be welcome!

tplessas commented 4 years ago

Still very much interested in contributing to the project. I have implemented support for many new TINs here, all ready to be pulled once I update the readme: https://github.com/tplessas/validator.js/tree/refactor-isTaxID

As part of that I have also added (or will be adding) implementations of the ISO 7064, Luhn and Verhoeff validation algorithms, which could be spun off as separate validators for any kind of compatible number (IMEI, SIM, credit card, various social security and ID numbers).

tplessas commented 4 years ago

...any news on interest? I have added all countries from the document, added tests and updated the readme.

profnandaa commented 4 years ago

@tplessas -- oh, sure, this is very much welcome. Let me fast-track closing on #1409 -- you can help with any clean-ups needed there in case the author is a bit held up?

tplessas commented 4 years ago

@profnandaa Of course, keeping an eye on it.

profnandaa commented 4 years ago

@tplessas -- over to you now 👍 #1409 merged.

firlus commented 4 years ago

Included german version.

1489