search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.31k forks source link

Email validation not working with 'require_tld' = true #1652

Open stevehobbsdev opened 3 years ago

stevehobbsdev commented 3 years ago

Describe the bug I am using isEmail to validate email addresses with require_tld set as the default of true, and noticed an anomaly:

example@example correctly fails validation.

example.example@example passes validation.

Given that require_tld is true I would have expected the second example to fail, or am I mistaken?

Additional context Validator.js version: 13.6.0 Node.js version: 12.9.1 OS platform: [windows, linux, macOS, etc] macOS

profnandaa commented 3 years ago

/cc. @tux-tn -- check if it has to do with #1651

tux-tn commented 3 years ago

Very strange behaviour, i can't even reproduce it with validator@13.6.0 (as you can see in this runKit ) @stevehobbsdev Can you share with us a code snippet with the issue?

stevehobbsdev commented 3 years ago

@tux-tn Odd - let me see if I can reproduce it will a small repro and get back to you, probably early next week.

tux-tn commented 3 years ago

@stevehobbsdev any news?

stevehobbsdev commented 3 years ago

@tux-tn I haven't had a chance to properly evaluate on our end yet, but it clearly works as intended from your runKit.

So at the moment it looks like it's an issue our end. Perhaps we could close this and I could come back to you if I find something more? Thanks for looking into it!