search

validatorjs / validator.js

String validation
MIT License
23.01k stars 2.29k forks source link

Mobile Phone validations - For The First Time Contributors #1761

Open ezkemboi opened 2 years ago

ezkemboi commented 2 years ago

I would like to give this to the people who are new and would like to start contributing to validator.js.

The current version in isMobilePhone validation, we have less than 195 phone validations i.e

In the code https://github.com/validatorjs/validator.js/blob/master/src/lib/isMobilePhone.js, the validations exist from line 5 to line 119, which means we have probably 119 - 5 countries phone validations. Where might be other countries? That is up to someone who would like to choose which country does not exist and create a new validation for the same.

When making this change, apart from the file above, also add tests and update the isMobilePhone section in the README.

Also, please check on existing PR's if the country you choose to validate mobile phone numbers does not have an already PR raised.

All Prs are welcomed and we will do a review on the same

pavolmarc commented 2 years ago

Hello, I would like to add Burundi validation.

tux-tn commented 2 years ago

Hello, I would like to add Burundi validation.

Thank you @pavolmarc ! You can go ahead and open a PR

LucasFab commented 2 years ago

Hi, I'm a student in 4th year looking to start working on open-source projects, can I contribute by working on this issue, if there is any phone number that would need to be added ?

tux-tn commented 2 years ago

@LucasFab Welcome ! Feel free to choose any locale that doesn't already exist (you check the existing list in the readme file) or that don't have any open PR

pavolmarc commented 2 years ago

@tux-tn Hello I opened a pull request ready to review - #1872

kuldp18 commented 2 years ago

@tux-tn Hello, I have added one country in the list, please review #1880. Thanks.

sarazm2000 commented 2 years ago

@tux-tn Hello, I have added Iceland phone validation.(#1885)

DevilsAutumn commented 2 years ago

hello, i would like to add validation for Lesotho!

YTeyddie22 commented 2 years ago

hello, i don't see the validation for Trinidad and Tobago. May i add it?

ezkemboi commented 2 years ago

Please add in separate PRs I case.

On Wed, Jan 19, 2022, 8:24 PM Teddy Yongo @.***> wrote:

hello, i don't see the validation for Trinidad and Tobago. May i add it?

— Reply to this email directly, view it on GitHub https://github.com/validatorjs/validator.js/issues/1761#issuecomment-1016693760, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALVWPHYVBP6GC5NI7PVBSCDUW3XTHANCNFSM5FSXM3NQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ajGingrich commented 2 years ago

PR for adding Nicaragua https://github.com/validatorjs/validator.js/pull/1909

Mustafiz04 commented 2 years ago

Hello, I still don't see validations for multiple countries. Can I work on it and add all of those ????

ezkemboi commented 2 years ago

Yes please @Mustafiz04

savannahvaith commented 2 years ago

Hello, I've found a couple more that can be added to the list - am I okay to work on those?

WikiRik commented 2 years ago

@savannahvaith go for it!

rksp25 commented 2 years ago

MONGOLIA is missing I am working on it

adida948 commented 2 years ago

Hello saw Aruba was not on the list. Shared the PR.

rksp25 commented 2 years ago

Hi I fix MONGOLIA missing from list fixed issue please find PR: https://github.com/validatorjs/validator.js/pull/1993

rksp25 commented 2 years ago

I am working on country Benin

rksp25 commented 2 years ago

Hi I fix BENIN missing from list fixed issue Please review PR: https://github.com/validatorjs/validator.js/pull/1997/

rksp25 commented 2 years ago

@profnandaa , others Please review PR: https://github.com/validatorjs/validator.js/pull/1997

kai2128 commented 2 years ago

added mobile phone validation for Papua New Guinea. PR: #2002

flamadev commented 1 year ago

Hi! i would like do my first contribution. It seems that Haití is not on the list either, could I work on that?

WikiRik commented 1 year ago

Hi! i would like do my first contribution. It seems that Haití is not on the list either, could I work on that?

@flamadev go for it!

flamadev commented 1 year ago

Hi! i would like do my first contribution. It seems that Haití is not on the list either, could I work on that?

@flamadev go for it!

Hi @WikiRik I done my PR, can you review it when you can ? Thank you! :)

shadybotros commented 1 year ago

Hey, I found that Burundi was missing and made my first contribution here: https://github.com/validatorjs/validator.js/pull/2065

Could someone please review it? :)

ezkemboi commented 1 year ago

Anyone can add as much as possible

Pulkit0729 commented 1 year ago

Hey, I found Barbados is missing from the list. Working on it.

Pulkit0729 commented 1 year ago

Hey, I found Barbados is missing from the list. Working on it.

2186

aidos42 commented 1 year ago

Hi!

Found that Wallis and Futuna was missing and made my first contribution here: https://github.com/validatorjs/validator.js/pull/2209

May someone please review it? :)

Siddhant-Kashyap commented 1 year ago

Hi! Founded that ' Guam ' phone number is not added in the list so i am adding it

2255

Please someone review it .

SimranSiddiqui commented 1 year ago

Hey! I would like to do my first contribution. I saw Malawi is not on the list. Can I work on that?

WikiRik commented 1 year ago

Hey! I would like to do my first contribution. I saw Malawi is not on the list. Can I work on that?

@SimranSiddiqui of course, go ahead! Do also check out what was done in the past; https://github.com/validatorjs/validator.js/pull/1823

SimranSiddiqui commented 1 year ago

Hey! I would like to do my first contribution. I saw Malawi is not on the list. Can I work on that?

@SimranSiddiqui of course, go ahead! Do also check out what was done in the past; https://github.com/validatorjs/validator.js/pull/1823

2267

ShambhavII-Singh commented 1 year ago

Hey! I did not find Croatia on the list. Can I add that? I will be making a PR shortly.

Manu024 commented 12 months ago

Hi Devs, I couldnt find Puerto Rico in the list. I would like to contribute by creating a PR?

Excited to start my first open source contribution if it helps.

I found myself to make the changes in readme, isMobilePhone.js, validators.test.js files. Did I missed anything?

WikiRik commented 12 months ago

Feel free to contribute to this. No need to ask permission, but do check if there is already an open PR with the locale.

Most useful sources are the ITU and libPhoneNumber from Google but additional (local) sources are also welcomed

Changes are indeed made in the README, isMobilePhone.js and validators.test.js

Manu024 commented 12 months ago

Created https://github.com/validatorjs/validator.js/pull/2292)/ PR for Puerto Rico . Please review.

Thanks in Advance

Swamynathan-R commented 11 months ago

created #2321 PR for Monaco, Please check and review.

Thank you.

sadraliev commented 8 months ago

Hello, can I create a PR to update the regular expression for Kyrgyzstan phone numbers? The ones currently in place are not up to date.

profnandaa commented 8 months ago

Pls do. Sorry we haven't done the pending release yet but I'm working on that.

./na

On Mon, Jan 8, 2024, 21:46 sadraliev @.***> wrote:

Hello, can I create a PR to update the regular expression for Kyrgyzstan phone numbers? The ones currently in place are not up to date.

— Reply to this email directly, view it on GitHub https://github.com/validatorjs/validator.js/issues/1761#issuecomment-1881636189 or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB7ZEMNJGPHUWWBX5Z2CMLYNQ5GRBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIYTANRWHE4DINRVGCSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRRGMYTSNRSGE3TAN5ENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWTDSNRVG44DFAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCMBSGA3DQNZWGEZIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTANRWHE4DINRVGCBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEZTCOJWGIYTOMBXU52HE2LHM5SXFJTDOJSWC5DF . You are receiving this email because you modified the open/close state.

Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

sadraliev commented 8 months ago

Created #2350 PR for Kyrgyz Republic . Please review.

Thanks in Advance! 🖖

ignaciosuarezquilis commented 4 months ago

Hi, it seems that vatican city is not listed, can I work on that?

jmustafa-96 commented 4 months ago

Hey! I would like to do my first contribution. I saw CONGO is not on the list. Can I work on that?

SurajSivakumar07 commented 4 months ago

Shall I add Vatican City validation ?

WikiRik commented 4 months ago

There's no way to pin a comment in GitHub, so I'll copy my earlier comment to here;

Feel free to contribute to this. No need to ask permission, but do check if there is already an open PR with the locale.

Most useful sources are the ITU and libPhoneNumber from Google but additional (local) sources are also welcomed

Changes are indeed made in the README, isMobilePhone.js and validators.test.js