search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.32k forks source link

PR Workflows: CodeQL v1 is deprecated #2149

Closed pano9000 closed 1 year ago

pano9000 commented 1 year ago

Describe the bug CodeQL v1 is getting deprecated This of course affects all of the pull requests here, since those tests will fail.

Since CodeQL is switching to Node.js 16, and this project for some reason still wants to be compatible with older unsupported Node.js projects still, I have no idea, if it is just enough to switch that "v1" into a "v2" inside https://github.com/validatorjs/validator.js/blob/master/.github/workflows/codeql-analysis.yml

Just wanted to bring this to the attention of everybody here.

WikiRik commented 1 year ago

CodeQL runs checks that are independent of the Node version/features so yes you can just open a PR to update v1 to v2 to solve this