search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.32k forks source link

Add ISO-15924 validation #2214

Open xDivisionByZerox opened 1 year ago

xDivisionByZerox commented 1 year ago

Description

Hello, I'm a core member of the @faker-js/faker library. We already use many of your validation methods to verify the integrity of our generated fake values.

For our newest addition, we want to verify codes for the representation of the names of scripts. Those are standardized by ISO-15924.

Suggested Validation

Validator name: isISO15924(str) Validator Description: Check whether or not the string is a valid 4 character, ISO-15924 script code.

Additional Information

I'm willing to open a PR that integrate this feature if it get's approved.

WikiRik commented 1 year ago

Go for it! Looking forward to the PR

xDivisionByZerox commented 1 year ago

Wow, that was fast. Thank you.

xDivisionByZerox commented 8 months ago

Hi @WikiRik, this Issue and the related PR are open for more than 8 months now. Is there anything I can do to help this moving forward? No pressure from my side, but I want to now what is going on 😄

WikiRik commented 8 months ago

I seemed to have missed the PR being opened, I will take a look at it. I do not have the rights to get it merged or anything so I can't really speed up that process. See also the recent discussion here; #2376

xDivisionByZerox commented 8 months ago

Thank you for picking this one up. Again, there is no pressure from my side. I simply did a quick review on all my open PRs/Issues and tried to move them forward.

I was not aware of the situation of this project. I'll see if I can take part in the discussion, as my team and I use this library quite often.