search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.31k forks source link

isPassport - Azerbaijan validation fails #2274

Closed amaliacatalina closed 6 months ago

amaliacatalina commented 1 year ago

Describe the bug The validation for an Azerbaijan passport number, fails. After a little research, I found out this:

"Each passport, no matter which category it belongs to, comes with a unique number. It starts with a letter followed by 8 digits,..."

The validation now, in Regex is : [A-Z]{2,3}\d{7,8}$, and i think it should be [A-Z]{1}\d{8}$. Correct me if i'm wrong?

WikiRik commented 1 year ago

The PR that added the regex (https://github.com/validatorjs/validator.js/pull/2061) did not have any source. The page where you got that quote from is likely https://www.byevisa.com/azerbaijan-passport/ but that also does not have a source. The Immigration and Refugee Board of Canada does have a link to Keesing Reference System (not freely accessible) which mentions that you are correct. See https://irb.gc.ca/en/country-information/rir/Pages/index.aspx?doc=455354&pls=1 and https://www.refworld.org/docid/53b14c614.html

Feel free to open a PR that fixes this.

stickyrst commented 1 year ago

https://github.com/validatorjs/validator.js/pull/2284

This pull fixes the issue but it was not approved/merged yet. Is there any chance anyone can approve and merge it?

stickyrst commented 1 year ago

Fix still not merged

stickyrst commented 1 year ago

Still not merged

rubiin commented 6 months ago

closing as the PR was merged