search

validatorjs / validator.js

String validation
MIT License
23.12k stars 2.31k forks source link

No Active Maintainers? New Maintainers Needed? How to Proceed? #2376

Open pano9000 opened 9 months ago

pano9000 commented 9 months ago

Hi all,

If you look at the growing number of stale "Pull Requests", it feels like this project is more or less in an unmaintained state. None of the (if I count correctly) 4 current maintainers is really active anymore on this repo.

This of course is not good, because it will keep people away from even trying to improve anything here. After all why should they waste their time, if there is no chance of their changes getting pulled in. Speaking for me: It definitely keeps me away from Reviewing Pull Requests.

It's a bit of a shame, because this is a really useful project.

How do you other people see it? Is there any way forward here? Or would we need to fork this into some kind of validator.js-ng project (and by doing so also have the chance to get rid of some technological debt that is there for "compatibility reasons"?)

WikiRik commented 8 months ago

Tagging @profnandaa @ezkemboi @rubiin @braaar since I'm interested to see what they think.

Personally, I think adding additional maintainers would be better for the project and I would refrain from going to a fork. Most of the PRs, issues and downloads will still be going here and I think we still have the chance to revive this repo. I have experienced the same feeling as you since I do have some refactoring and removing technical debt that I want to work on (like #1874 and #2159 ) but that I haven't worked on recently since chances of it being merged anytime soon are small

rubiin commented 8 months ago

I think we can pick some users from the active contributors.

profnandaa commented 8 months ago

I'm open to the idea of adding more maintainers to help. I think it has just happened that most of us I've been caught up with other stuff.

I'll be around to provide operational support.

Can I get some proposals for those who would like to be maintainers? Please link the currently open PRs they have reviewed.

Above all, thanks for your concern! ❤️

PS. I should get some time this coming weekend to prepare a release. I had several build errors last time that put me off.

-na

ezkemboi commented 8 months ago

Add to the meet for release @Anthony Nandaa @.***>

On Tue, Mar 5, 2024, 4:19 PM Anthony Nandaa @.***> wrote:

I'm open to the idea of adding more maintainers to help. I think it has just happened that most of us I've been caught up with other stuff.

I'll be around to provide operational support.

Can I get some proposals for those who would like to be maintainers? Please link the currently open PRs they have reviewed.

Above all, thanks for your concern! ❤️

PS. I should get some time this coming weekend to prepare a release. I had several build errors last time that put me off.

-na

— Reply to this email directly, view it on GitHub https://github.com/validatorjs/validator.js/issues/2376#issuecomment-1978762121, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALVWPH5GFWRXWR4HIBHHWS3YWXA57AVCNFSM6AAAAABDL4FEE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYG43DEMJSGE . You are receiving this because you were mentioned.Message ID: @.***>

braaar commented 7 months ago

I think I would have to decline a full on maintainer role even though I am rather invested in this library. My time needs to be prioritised downstream in https://github.com/typestack/class-validator, where I am now a maintainer.

As with class-validator, I don't think a rut in activity is a reason to fork and divide the community. We rather need to focus more on building a community of people helping each other out. For class-validator we have set up a triage team to help handle much of the issue and PR workload.

smngvlkz commented 6 months ago

If the workload is too much for the current maintainers. I am open to becoming a maintainer here too, just to open, close or label issues. Honestly just offering my services to lighten the load and make this project better.

rubiin commented 6 months ago

@profnandaa what do you think on onboarding few new members from active contributor list

profnandaa commented 6 months ago

I'm down for that. Also thinking of having you and @WikiRik finally take full maintainer (merge) roles -- also can get ready to prep the next release.

I'll have the publishing rights for now but also work on transitioning that too.

We'll just need to establish a few ground rules on ownership and responsibility. I'll work on that.

rubiin commented 6 months ago

Sure thing. Down to that as well

ezkemboi commented 6 months ago

@profnandaa yes, please do the ground rules on ownership and responsibility and all will be good.

pano9000 commented 2 months ago

any news on the ground rules mentioned above?

I would like to be more active here as well, but currently my time is not fully permitting it, but that hopefully should change within the next 6 months

rubiin commented 1 day ago

For now, I only have access to the repo . So anything related to publishing the package on npm is sadly out of my hands. I think reviews aside, we should be doing a regular version update following semver so as not to push loads of changes in a single release. This would help the library maintain its active presence too