validatorjs / validator.js

String validation
MIT License
23.12k stars 2.31k forks source link

The rename/move broke the bower package #252

Closed aroman closed 10 years ago

aroman commented 10 years ago

Basically, 'validator' is already a package on bower:

~ $ bower info validator
bower cached        git://github.com/cam-stitt/validator.git#0.0.4
bower validate      0.0.4 against git://github.com/cam-stitt/validator.git#*

{
  name: 'validator',
  main: 'validator.js',
  version: '0.0.4',
  authors: [
    'Cameron Stitt <cameron@castitt.com>'
  ],
  description: 'Easy JavaScript form validation.',
  license: 'MIT',
  homepage: 'https://github.com/cam-stitt/validator'
}

Available versions:
  - 0.0.4
  - 0.0.3
  - 0.0.2
  - 0.0.1

You can request info for a specific version with 'bower info validator#<version>' 

So there's some clobbering going on in bower right now. What can be done to fix this?

aroman commented 10 years ago

For anyone else who might want to install validator through bower right now, of course the following works:

  "dependencies": {
    ...
    "validator": "git@github.com:chriso/validator.js.git#3.2.0",
  }
chriso commented 10 years ago

Not much we can do about conflicts in a flat namespace. Is validator.js taken?

aroman commented 10 years ago

Unfortunately yes, by https://github.com/guillaumepotier/validator.js.

See: http://sindresorhus.com/bower-components/#!/search/validator

chriso commented 10 years ago

:confused: not sure then. I could suggest in the README that people install from git but then they need to manually specify a version or take the risk with HEAD.

aroman commented 10 years ago

yeah, i guess you could ask the guy who owns https://github.com/cam-stitt/validator to unlist his (apparently unmaintained) module from bower, or you could list this module on bower under a different name such as "validatorjs" (which isn't taken).

But yeah, in the meantime I'm just specifying the version via github with the 3.2.0 release tag. If you don't want to compromise the name in bower, I'd suggest putting a note about that workaround in the README and closing this issue.