valignatev / heaven-and-hell

Emacs light/dark theme toggler
MIT License
58 stars 2 forks source link

Icon background in tab not switching #14

Open yavitzour opened 4 years ago

yavitzour commented 4 years ago

Hi,

Love this package - I often switch between light and dark themes.

I'm using doom emacs, and I have a tiny problem - after switching, the backgrounds of the icons in the tab bar are not switching to the new theme until I switch buffer. For example, after switching from light to dark I get the following image (look at the tab bar at the top):

after_hh

After switching buffers the quirk is gone we go back to the normal look:

after_buffer_switch

The same thing happens when switching from dark to light. Is there some function to refresh the tab bar after switching themes?

Thanks, Yoav

valignatev commented 4 years ago

Hey, thanks for using the package! I haven't used the tabs ever, so not surprised it went over me :) Is that brand new emacs 27 tabs or some external package?

yavitzour commented 4 years ago

Yeah, it's new to me too, but I quite like it:)

I'm using emacs 27, but I'm using doom-emacs with the tabs module from doom, so I'm not completely sure what's happening under the hood. I believe he is using a package called centaur-tabs, but I'm not sure how they interact with the built-in emacs 27 tabs.

valignatev commented 4 years ago

I see, thanks, I guess it's time for me to upgrade my 6 months old doom and check these tabs out :)