search

valignatev / heaven-and-hell

Emacs light/dark theme toggler
MIT License
58 stars 2 forks source link

Breaks colors in terminal #6

Closed adrianstaniec closed 6 years ago

adrianstaniec commented 6 years ago

Your package works very nicely in graphical mode, but it breaks the theme 256color look in the terminal, compared to just (load-theme ' t) seen on emacs 25.3

valignatev commented 6 years ago

Thanks for the report! Honestly, I never tested it in the terminal :) I'll try to fix it. Can you also tell me what themes have you tried?

valignatev commented 6 years ago

I've tried spacemacs light/dark, they seem to work fine.

valignatev commented 6 years ago

Also, I'm interested in what terminal emulator you're using and if it has true color support

adrianstaniec commented 6 years ago

I'm sorry, I think the problem is with the theme not you package.

I was trying with solarized-dark, and indeed just loading with on startup with load-theme works, and doing it via your package not, but I get the same problem when loading that theme with counsel-load-theme, so I blame it on the theme now

To answer your question, i am using st, but that should matter.

valignatev commented 6 years ago

Glad that you've sorted that out :+1: