search

valimised / evalimine

e-hääletamise tarkvara
Other
726 stars 105 forks source link

Estonian language #6

Open AlexRevin opened 11 years ago

AlexRevin commented 11 years ago

I would highly recommend avoid using Estonian language in:

  1. Comments
  2. Function names
  3. Variable names
  4. Log outputs

As release was open-sourced and highly advertised, many people just can't read code as they do not understand that language.

millette commented 11 years ago

It's not open source software according to either FSF or OSI since it's a non-derivative, non-commercial licence.

AlexRevin commented 11 years ago

You are totally right, I have missed the license description. But that does not make any big difference. Since the code cannot be changed, no pull-requests can be made and code is obviously here for demonstration purposes only, could you please leave that issue open, as the code is not readable for anyone who does not speak Estonian.

reijovosu commented 11 years ago

Either way, writing strings to the code is bad practice anyhow. Also writing comments in other language than english. I could offer to translate it to english, if project authors would prepare translation example.

Any application should be ready for multilingual support by just translating strings.