valinet / ExplorerPatcher

This project aims to enhance the working environment on Windows
GNU General Public License v2.0
24.82k stars 1.05k forks source link

Crash when trying to enable systray icon #2273

Open mexmer opened 1 year ago

mexmer commented 1 year ago

I installed on test machine new build of explorer patcher (22621.2361.58.4) on top of latest Windows 11 22H2 (build 10.0.22621.2283) i noticed that i'm not seeing any notification icon in systray (except network and volume), unless i click arrow, so i thought my setting for them did reset, and wanted to enable them.

when i click "customize sytem icons in notification area", it opens control panel, but always crashes

when i click "customize notification area icons" it opens dialog when i try to change any from "notification only" to "show icon & notifications", it either crashes, or regardles what i change, it doesn't save when i click ok, and no icons are displayed.

when i select "show all icons", it works, but before i could have selected only part of icons.

also seems this works properly on Windows 11 21H2 (build 10.0.22000.2416)

pyrates999 commented 1 year ago

Check that symbols were downloaded: https://github.com/valinet/ExplorerPatcher/wiki/Symbols

For Windows 11 21H2 (build 10.0.22000.2416), I would update to 22H2.

Please include what settings you changed in explorer patcher properties application.

For the system tray icons, you can set it to show all icons.

mexmer commented 1 year ago

@pyrates999 it's 22H2 where is it crashing. on 21H2 it's works, and no i can't upgrade that machine, it's centrally managed what version we use.

as for what settings changed, i did not change anything. i just noticed that there is no icons visible in my systray on test machine (which has latest noninsider builder of windows), so i wanted to get them back.

in properties i have symbols download enabled, so i expect application itself did download latest symbols.

pyrates999 commented 1 year ago

I would not be installing EP on a work computer then. Leave it to your home computer to install EP.

GitPopcorn commented 1 year ago

I got same issue like this after I resolve last one...

This is the console log I have captured, nothing showed in it. If it crashed, the console will be restart soon and no logs retained.

Running on Windows 11, OS Build 10.0.22621.2361.
Loaded symbols
Setup user32 functions done
CAppResolverCacheBuilder::_AddUserPinnedShortcutToStart() = 46F60
Patched taskbar transparency in newer OS builds
ITrayUIHost = 3A52B8
Setup explorer functions done
Setup uxtheme functions done
[AC] rcMonitorAssignment = 3F9B1
[AC] rcWorkAssignment = 3FA61
[AC] blockBegin = 3F9C6
[AC] blockEnd = 3FA77
[AC] Patched!
[CC] rcMonitorAssignment = 3AFAB
[CC] rcWorkAssignment = 3B078
[CC] blockBegin = 3AFC3
[CC] blockEnd = 3B091
[CC] Patched!
[TC] rcMonitorAssignment = 3B8C0
[TC] rcWorkAssignment = 3B976
[TC] blockBegin = 3B8DA
[TC] blockEnd = 3B98F
[TC] Patched!
[TV] firstCallPrep = 2A385
[TV] firstCallCall = 2A38F
[TV] Patched!
[HC] match1 = 1D55D
[HC] match2 = 1D624
[HC] writeAt = 1D21E
[HC] cleanup = 1D635-1D64A
[HC] Patched!
PenMenuSystemTrayManager::GetDynamicSystemTrayHeightForMonitor() = 456650
Setup twinui.pcshell functions done
Setup combase functions done
Setup twinui functions done
Setup stobject functions done
Setup bthprops functions done
Setup pnidui functions done
Setup shell32 functions done
Setup windows.storage functions done
[IME] Context menu patch status: 1
Setup inputswitch functions done
Setup windowsudk.shellcommon functions done
Setup peopleband functions done
Installed hooks.
Play startup sound thread...
Signal shell ready...
Started "Signal shell ready" thread.
Open Start on monitor thread
Started "Open Start on current monitor" thread.
EP Service Window thread
Initialized taskbar centering module.
[Positioning] Added settings for monitor 0000000000010001 : 0
Registered Win+A, Win+B, and Win+N
Progman: 919884
Progman hook: 524709
>>> Signal shell ready.
Setup sndvolsso functions done
Ended "Signal shell ready" thread.
0 0
Started "Play startup sound" thread.
Ended "Play startup sound" thread.
[Updates] Starting daemon.
[Updates] Configured update policy on this system: "Check for updates but let me choose whether to download and install them".
[Updates] Path to module: C:\WINDOWS\dxgi.dll
[Updates] Checking against hash "22622.2361.58.4.f0ab2cdb0cc00ced"
[Updates] Update URL: https://github.com/valinet/ExplorerPatcher/releases/latest/download/ep_setup.exe
[Updates] Hash of remote file is "22622.2361.58.4.f0ab2cdb0cc00ced" (valid).
[Updates] Local version obtained from hash is 22622.2361.58.4.
[Updates] No updates are available.
10000 46000000
0 46000000
[EnsureXAML] 15 ms.

Windows Version: 22H2 22621.2361 EP Version: 22621.2361.58.4

GitPopcorn commented 1 year ago

I installed on test machine new build of explorer patcher (22621.2361.58.4) on top of latest Windows 11 22H2 (build 10.0.22621.2283) i noticed that i'm not seeing any notification icon in systray (except network and volume), unless i click arrow, so i thought my setting for them did reset, and wanted to enable them.

when i click "customize sytem icons in notification area", it opens control panel, but always crashes

when i click "customize notification area icons" it opens dialog when i try to change any from "notification only" to "show icon & notifications", it either crashes, or regardles what i change, it doesn't save when i click ok, and no icons are displayed.

when i select "show all icons", it works, but before i could have selected only part of icons.

also seems this works properly on Windows 11 21H2 (build 10.0.22000.2416)

Found a easy way to resolve this, dude:

Just to drag and drop icons.

Unable to customize Systray icons #1157

topia topia commented on Mar 26 Is this the same problem as described in https://github.com/valinet/ExplorerPatcher/discussions/1172#discussion-4990862 ? > If so, you can drag and drop icons.

jwgn Author jwgn commented on Mar 26 Dragging and dropping items seem to work 👍

Gorpalicious Gorpalicious commented on May 2 I had the same issue but the drag & drop method seems to work

mexmer commented 1 year ago

thanks, this workaround works indeed, i did disable "display all" and dragged only icons i need.