valinet / ExplorerPatcher

This project aims to enhance the working environment on Windows
GNU General Public License v2.0
22.22k stars 976 forks source link

Latest round of windows 11 updates broke Explorer Patcher again #2439

Closed alandsidel closed 6 months ago

alandsidel commented 6 months ago

Today I installed several Windows 11 updates:

One of these caused an incompatibility with EP, resulting in the start menu being unable to open either through the windows key, ctrl-esc, or the mouse. I had to uninstall EP to get control of Explorer back.

Mondays, eh?

aemsx commented 6 months ago

same here. windows has just been updated to build 22621.2715. also windows 11 context menu seems to crash the explorer / ep.

Amrsatrio commented 6 months ago

Please revert to 22621.2506 or 22621.2428 and pause for 5 weeks for the time being. I'll investigate shortly.

Amrsatrio commented 6 months ago

Have you tried checking the "Disable the Windows 11 context menu?" in EP Properties > Explorer? Because with that enabled, I have no issues even with the start menu. Everything worked as they were.

Amrsatrio commented 6 months ago

I'm using the Windows 7 command bar here with latest prerelease EP.

image

Amrsatrio commented 6 months ago

same here. windows has just been updated to build 22621.2715. also windows 11 context menu seems to crash the explorer / ep.

Regarding Windows 11 context menus, it has been this way since 22621.2134+. I still haven't found a proper fix for this yet. https://github.com/valinet/ExplorerPatcher/issues/2218

alandsidel commented 6 months ago

Please revert to 22621.2506 or 22621.2428 and pause for 5 weeks for the time being. I'll investigate shortly.

Personally can't do this, but I can live without EP (somehow) until you figure out what's up. Thanks!

Amrsatrio commented 6 months ago

Maybe the only way I can figure this out is by updating a number of my PCs and laptops to 2716... I suspect this has something to do with feature flags that broke EP for some reason

Amrsatrio commented 6 months ago

image If you can download ViVeTool and run vivetool /query > output.txt and sending the output.txt, it might be helpful for me.

alandsidel commented 6 months ago

image If you can download ViVeTool and run vivetool /query > output.txt and sending the output.txt, it might be helpful for me.

As requested!

output.txt

Amrsatrio commented 6 months ago

So your issue is only start menu refusing to open? Or did your Explorer crash when trying to open it? Did you see any Error lines with Applicaton Error as the source?

image

That is the screenshot from someone else in our Discord that is experiencing an Explorer crash which I could not reproduce as well.

alandsidel commented 6 months ago

So your issue is only start menu refusing to open? Or did your Explorer crash when trying to open it?

Explorer wasn't crashing, but the start menu wasn't opening it. The task manager and task bar were fine. I ended and restarted the explorer process from task manager manually once to see if it would fix anything, no dice. The key shortcuts to open the start menu did "nothing" and clicking on it just showed the circular spinner for a moment.

Can't spend any more time on this right now, but if you need further debugging stuff I'll do what I can in 12h or so.

Amrsatrio commented 6 months ago

Yep. I'll wait till then. Maybe the first page of the full screened console output will help. I have assignments due really shortly now so I can't investigate deeply for now.

tbcam88 commented 6 months ago

Yeah, the KB5032190 update seems responsible, serious lag when opening explorer windows etc.

I uninstalled the above update and things have reverted to normal - hopefully we get a fix! 👌

EDIT: I've since tried fully uninstalling ExplorerPatcher (including removing registry entries), then allowing the KB5032190 update to take place a second time and again installing EP after the fact. For me, this completely resolved the issue and Windows is running again lag-free as intended. Worth a try for anybody experiencing similar!

Amrsatrio commented 6 months ago

@tbcam88 Which File Explorer control interface are you using?

Amrsatrio commented 6 months ago

I mean, this part.

image

The Windows 11 command interface has known issues to be breaking with ExplorerPatcher installed, atleast there are two reports. One on 2361, and another one on 2715. Strangely I could not reproduce those issues.

Just saying, the Windows 11 command bar especially the one with modern navigation bar inherently has serious lagging issues even when EP is not installed.

Maybe you can record a video of the issue you're experiencing?

aemsx commented 6 months ago

Have you tried checking the "Disable the Windows 11 context menu?" in EP Properties > Explorer? Because with that enabled, I have no issues even with the start menu. Everything worked as they were.

Yes, this is a workaround but does not fix the issue

Regarding Windows 11 context menus, it has been this way since 22621.2134+. I still haven't found a proper fix for this yet. #2218

It 100% woked in the build I had before (Win 10 taskbar + Win 11 context menu) - not sure which one i had but I guess it was 22621.2506 or 22621.2428. It just stopped after the windows updates that were installes last night.

Also symbols can't be downloaded anymore - guess they're just not existing yet.

Amrsatrio commented 6 months ago

So you really want to use the Windows 11 right click with non-Windows 11 command bar?

aemsx commented 6 months ago

So you really want to use the Windows 11 right click with non-Windows 11 command bar?

It's not vital - but if there is an option for it within EP it should work. Otherwise the option should be removed I guess.

Amrsatrio commented 6 months ago

Yeah that is my plan. I want to remove it rather than making it not crash under non-Windows 11 command bar.

Amrsatrio commented 6 months ago

EP does not run as its own executable. Even if you have EP registered as shell extension, it won't be injected into the Notepad app because it is a UWP app. Which means there might be other tweak software that you installed, that happened to conflict with EP. (Wallpaper Engine is considered one.) Are there any?

I seriously experience no issues with the latest update on my laptop whose customization software is only EP. This way, diagnosing the issue to make a proper fix can take a long time which is until I see the issue in person.

alandsidel commented 6 months ago

Explorer wasn't crashing, but the start menu wasn't opening it. The task manager and task bar were fine. I ended and restarted the explorer process from task manager manually once to see if it would fix anything, no dice. The key shortcuts to open the start menu did "nothing" and clicking on it just showed the circular spinner for a moment.

Can't spend any more time on this right now, but if you need further debugging stuff I'll do what I can in 12h or so.

Yep. I'll wait till then. Maybe the first page of the full screened console output will help. I have assignments due really shortly now so I can't investigate deeply for now.

What console output do you mean here? Will provide it today if possible.

pyrates999 commented 6 months ago

Explorer wasn't crashing, but the start menu wasn't opening it. The task manager and task bar were fine. I ended and restarted the explorer process from task manager manually once to see if it would fix anything, no dice. The key shortcuts to open the start menu did "nothing" and clicking on it just showed the circular spinner for a moment.

Can't spend any more time on this right now, but if you need further debugging stuff I'll do what I can in 12h or so.

Yep. I'll wait till then. Maybe the first page of the full screened console output will help. I have assignments due really shortly now so I can't investigate deeply for now.

What console output do you mean here? Will provide it today if possible.

Open up the properties application for explorer patcher, go to advanced, and click on enable console.

alandsidel commented 6 months ago

Explorer wasn't crashing, but the start menu wasn't opening it. The task manager and task bar were fine. I ended and restarted the explorer process from task manager manually once to see if it would fix anything, no dice. The key shortcuts to open the start menu did "nothing" and clicking on it just showed the circular spinner for a moment.

Can't spend any more time on this right now, but if you need further debugging stuff I'll do what I can in 12h or so.

Yep. I'll wait till then. Maybe the first page of the full screened console output will help. I have assignments due really shortly now so I can't investigate deeply for now.

What console output do you mean here? Will provide it today if possible.

Open up the properties application for explorer patcher, go to advanced, and click on enable console.

Ah, no can do as it's not installed now. Might be able to do this later. Probably best to just set up a VM to test this stuff if @Amrsatrio can't do so himself.

Amrsatrio commented 6 months ago

If the start menu was crashing then at least a crash log from event viewer related to StartMenuExperienceHost.exe might help.

alandsidel commented 6 months ago

If the start menu was crashing then at least a crash log from event viewer related to StartMenuExperienceHost.exe might help.

Attached several error logs from the event viewer detailing the crash. The only real difference between them is that it seems to alternate back and forth regarding the exception. Half of them are access violations (0xc0000005) and the other half are user callback exceptions (0xc000041d). They seem to come in pairs with the access violation first, then the callback exception a second or two later. This probably coincides with the "spinner" time starting and ending after hitting the WIN key or clicking it with the mouse. 2s sounds about right.

Rename .txts to .xml, github won't allow direct XML attachments. crash01.txt crash02.txt crash03.txt crash04.txt crash06.txt

Amrsatrio commented 6 months ago

The crashes happen in StartDocked.dll, which is the Windows 11 start menu. Still though strangely it doesn't crash on my laptop that I just updated.

alandsidel commented 6 months ago

I've just installed the latest release, and it seems to be working fine. The setup file is a different size from the last one I'd installed, so I presume it was a somewhat older version. I last updated shortly after the OSD bug was fixed, as that also afflicted me.

The md5 hash of the last installer I used prior to the latest one is d56736c633d0b5db571501e77830251a

Amrsatrio commented 6 months ago

I was about to tell you to update but I forgot for some reason, sorry 😂

Closing this issue then due to user error.