valinet / ExplorerPatcher

This project aims to enhance the working environment on Windows
GNU General Public License v2.0
24.1k stars 1.04k forks source link

Explorer Crashes and Restarts When Right-Clicking the Windows logo or using Win+X Menu #2617

Closed MG665 closed 7 months ago

MG665 commented 9 months ago

Summary Right clicking the Windows Start Menu (Or using the Win+X shortcut) after launching an app from it causes Explorer to crash and restart.

Steps to Reproduce

  1. Launch any app or option from the Start Menu by accessing it via Win+X
  2. Right click the Start Menu icon
  3. Explorer will crash and automatically restart

Expected Behavior Right clicking the Start Menu or using Win+X should not cause Explorer to crash.

Actual Behavior After launching something from the Win+X shortcut, using it again or right clicking the same menu causes Explorer to crash and restart.

Event Log Details Below are the events logged when the crash occurs:

Faulting application: explorer.exe
Version: 10.0.22621.2792
Timestamp: 0xfbda1990

Faulting module: twinui.pcshell.dll
Version: 10.0.22621.2861
Timestamp: 0xa5744518

Exception code: 0xc0000005
Fault offset: 0x00000000000210b9

Process ID: 0x0xE8C
Start time: 0x0x1DA365829406FEB

Path: C:\WINDOWS\explorer.exe
Module path: C:\WINDOWS\SYSTEM32\twinui.pcshell.dll

Report Id: f917bc18-6bd6-4a9e-8d76-70ccfa6c57db

This suggests the crash may be related to the twinui.pcshell.dll module.

System Details
Windows 11 version 23H2
pyrates999 commented 9 months ago

Check what happens when using the console in explorer patcher. Open up the properties application for explorer patcher, go to advanced, and click on enable console.

MG665 commented 9 months ago

Console just restarts with Explorer when it crashes:

Running on Windows 11, OS Build 10.0.22631.2861.
Loaded symbols
Setup user32 functions done
CAppResolverCacheBuilder::_AddUserPinnedShortcutToStart() = 47780
Patched taskbar transparency in newer OS builds
ITrayUIHost = 3AD318
explorer.exe!TrayUI_CreateInstance() = 1974AC
Setup explorer functions done
Setup uxtheme functions done
[AC] rcMonitorAssignment = 247F1
[AC] rcWorkAssignment = 248A1
[AC] blockBegin = 24806
[AC] blockEnd = 248B7
[AC] Patched!
[CC] rcMonitorAssignment = 66EFB
[CC] rcWorkAssignment = 66FC8
[CC] blockBegin = 66F13
[CC] blockEnd = 66FE1
[CC] Patched!
[TC] rcMonitorAssignment = 5B6A0
[TC] rcWorkAssignment = 5B756
[TC] blockBegin = 5B6BA
[TC] blockEnd = 5B76F
[TC] Patched!
[TV] firstCallPrep = 2F665
[TV] firstCallCall = 2F66F
[TV] Patched!
[HC] match1 = 1D56D
[HC] match2 = 1D634
[HC] writeAt = 1D22E
[HC] cleanup = 1D645-1D65A
[HC] Patched!
PenMenuSystemTrayManager::GetDynamicSystemTrayHeightForMonitor() = 45C760
Setup twinui.pcshell functions done
Setup combase functions done
Setup twinui functions done
Setup stobject functions done
Setup bthprops functions done
Setup pnidui functions done
Setup shell32 functions done
Setup windows.storage functions done
[IME] Context menu patch status: 1
Setup inputswitch functions done
wil::details::FeatureImpl<__WilFeatureTraits_Feature_Servicing_TaskbarMultiMon_38545217>::__private_IsEnabled() = 10BEB8
Setup windowsudk.shellcommon functions done
Setup peopleband functions done
Installed hooks.
Play startup sound thread...
Signal shell ready...
Started "Signal shell ready" thread.
Open Start on monitor thread
Started "Open Start on current monitor" thread.
EP Service Window thread
Initialized taskbar centering module.
Registered Win+A, Win+B, and Win+N
Progman: 330978
Progman hook: 65471267
[Positioning] Added settings for monitor 00000000050F0D97 : 0
[Positioning] Added settings for monitor 0000000018F50859 : 0
>>> Signal shell ready.
Setup sndvolsso functions done
Ended "Signal shell ready" thread.
0 0
[EnsureXAML] 16 ms.
Started "Play startup sound" thread.
Ended "Play startup sound" thread.
[Updates] Starting daemon.
[Updates] Configured update policy on this system: "Check for updates but let me choose whether to download and install them".
[Updates] Path to module: C:\WINDOWS\dxgi.dll
[Updates] Checking against hash "22622.2861.62.2.c2b7c0292fff8608"
[Updates] Update URL: https://github.com/valinet/ExplorerPatcher/releases/latest/download/ep_setup.exe
[Updates] Hash of remote file is "22622.2861.62.2.c2b7c0292fff8608" (valid).
[Updates] Local version obtained from hash is 22622.2861.62.2.
[Updates] No updates are available.
pyrates999 commented 9 months ago

Maybe one of the developers knows this, but is there a log kept of the console output by EP?

Amrsatrio commented 7 months ago

If you were referring to the Terminal entry, then it's already known. Other than those entries, I can't reproduce this bug. Sorry.