search

valinet / ExplorerPatcher

This project aims to enhance the working environment on Windows
GNU General Public License v2.0
24.61k stars 1.05k forks source link

Start+X is broken after update to 22635.4291 #3768

Closed brjsp closed 3 weeks ago

brjsp commented 3 weeks ago

explorerPatcher version 22621.3880.66.6

Tried both “Windows 10” and “Windows 10 (ExplorerPatcher)” taskbar styles.

Amrsatrio commented 3 weeks ago

Symbols downloaded?

pyrates999 commented 3 weeks ago

Check if symbols were downloaded: https://github.com/valinet/ExplorerPatcher/wiki/Symbols

Open up EP properties application and go to advanced, and check that Enable symbols download is ticked.

Symbols need to be downloaded for every new update of windows because they change with each new update for windows.

You can check using the console in explorer patcher. Open up the properties application for explorer patcher, go to advanced, and click on enable console. If it shows it can't download symbols, your version of windows is not supported.

brjsp commented 3 weeks ago

I recall Start+X previously working even on builds with missing symbols so it's probably not this.

pyrates999 commented 3 weeks ago

check that you've got symbols downloaded first.

brjsp commented 3 weeks ago

The cosole shows this on the beginning:

Running on Windows 11, OS Build 10.0.22635.4291.
Loaded symbols
Setup user32 functions done
pyrates999 commented 3 weeks ago

Please post the entire output from the EP console. And try pressing winkey+X and include the output from that.

brjsp commented 3 weeks ago

In the meantime updated to .4300, the problem still appears.

Running on Windows 11, OS Build 10.0.22635.4300.
Loaded symbols
Setup user32 functions done
CAppResolverCacheBuilder::_AddUserPinnedShortcutToStart() = 4EB80
ITrayUIHost = 3E9468
explorer.exe!TrayUI_CreateInstance() = 1D9E2C
Setup explorer functions done
Setup uxtheme functions done
Failed to hook CLauncherTipContextMenu::ShowLauncherTipContextMenu(). rv = 7
[AC] rcMonitorAssignment = 1ABA1
[AC] blockBegin = 1ABB2
[AC] blockEnd = 1AC20
[AC] Patched!
[CC] rcMonitorAssignment = 4009A7
[CC] rcWorkAssignment = 400A1F
[CC] blockBegin = 4009BB
[CC] blockEnd = 400A38
[CC] Patched!
[TC] rcMonitorAssignment = 418F02
[TC] blockBegin = 418F17
[TC] blockEnd = 418F84
[TC] Patched!
[TV] firstCallPrep = 2E07A
[TV] firstCallCall = 2E084
[TV] Patched!
[HC] match1 = 1CD6D
[HC] match2 = 1CE34
[HC] writeAt = 1CA2E
[HC] cleanup = 1CE45-1CE5A
[HC] Patched!
PenMenuSystemTrayManager::GetDynamicSystemTrayHeightForMonitor() = 46FCA0
[SMA] matchVtable = 79B1E8
[SMA] matchSingleViewShellExperienceFields = 10C74D
[SMA] matchAnimationHelperFields = 10C78C, +0x240, +0x260
[SMA] matchTransitioningToCortanaField = 425114, +0x2C8
[SMA] CStartExperienceManager::GetMonitorInformation() = F2E58
[SMA] CExperienceManagerAnimationHelper::Begin() = 73544C
[SMA] CExperienceManagerAnimationHelper::End() = 2C2A52
[SMA] matchHideA in CStartExperienceManager::Hide() = 2200D
[SMA] matchHideB in CStartExperienceManager::Hide() = 2204D
[SMA] Advertising successful animations patching.
[JVP] matchOffsetTrayStuckPlace = 429FCA
[JVP] matchOffsetRcWorkArea = 42A06C
[JVP] matchEnsureWindowPosition = 42857C
Setup twinui.pcshell functions done
Setup combase functions done
Setup twinui functions done
Setup stobject functions done
Setup bthprops functions done
Setup pnidui functions done
Setup shell32 functions done
Setup windows.storage functions done
[IME] Context menu patch status: 1
Setup inputswitch functions done
Setup peopleband functions done
Installed hooks.
Open Start on monitor thread
Started "Signal shell ready" thread.
Started "Open Start on current monitor" thread.
EP Service Window thread
Initialized taskbar centering module.
Registered Win+A, Win+B, and Win+N
[Positioning] Added settings for monitor 0000000002910649 : 0
[Positioning] Added settings for monitor 0000000000030059 : 0
Progman: 131576
Progman hook: 131553
Setup sndvolsso functions done
Ended "Signal shell ready" thread.
[Updates] Starting daemon.
[Updates] Configured update policy on this system: "Check for updates but let me choose whether to download and install them".
[Updates] Path to module: C:\WINDOWS\dxgi.dll
[Updates] Using hardcoded hash.
[Updates] Checking against hash "22622.3880.66.6.57999ff163192946"
[Updates] Update URL: https://github.com/valinet/ExplorerPatcher/releases/latest/download/ep_setup.exe
0 0
[Updates] Hash of remote file is "22622.3880.66.6.57999ff163192946" (valid).
[Updates] Local version obtained from hash is 22622.3880.66.6.
[Updates] No updates are available.

Pressing Start+X or right clicking the start button in taskbar produces no new entries in log.

pyrates999 commented 3 weeks ago

Thank you. Please wait for a developer to respond.

brjsp commented 3 weeks ago

Can no longer reproduce the problem in 22635.4317

pyrates999 commented 3 weeks ago

just clarify, did you mean 22631.4317? https://support.microsoft.com/en-us/topic/october-8-2024-kb5044285-os-builds-22621-4317-and-22631-4317-c1aba548-fc93-420e-855f-8594157c3e9e

brjsp commented 3 weeks ago

no, i mean 22635 the EP level (fake build number) and the patch level are independent from each other (but i doubt EP level is relevant to ExplorerPatcher)

pyrates999 commented 3 weeks ago

I'm talking about the windows build number.

brjsp commented 3 weeks ago

The windows build number as displayed in winver is 22635.4317.

22635 is the EP (Enablement Payload) version (22621/22622/22623/22624/22631/22635 are all otherwise the same OS version, only differing by which EPs you have installed) 4317 is the LCU (Latest Cumulative Update) version (Package_for_RollupFix)

pyrates999 commented 3 weeks ago

That's an insider preview build: https://blogs.windows.com/windows-insider/2024/10/04/announcing-windows-11-insider-preview-build-22635-4300-beta-channel/

Expect stuff to break with it.