valinet / WinCenterTitle

WinCenterTitle is a simple tool that allows you to center align the text in Windows 10 titlebars, the same way it was in Windows 8, 8.1, or even 3.1.
GNU General Public License v2.0
157 stars 16 forks source link

Doesn't work on Windows 11 22H2 #23

Open shinywong opened 2 years ago

shinywong commented 2 years ago

Symbols are downloaded, but title bar texts are not centered.

WinCenterTitle version: 1.3.0.0.

AromaKitsune commented 2 years ago

I have a same problem. Even though the cmd window says that WCT successfully injected library into DWM

WinCenterTitle
==============
1. Hook Library Path: C:\WinCenterTitle\WinCenterTitleLibrary.dll
2. Hook Library Entry Point: 0x1e20
3. LoadLibraryW address: -854741280
3. FreeLibrary address: -854754816
4. Found application, PID: 1084
5. Wrote library path in application's memory.
6. Successfully injected library into application.
7. Freed path from application's memory.
8. Found library in application's memory (113/116).
10. Successfully created message window (328536).
I

After a few secs, WinCenterTitle exited. I also tried running it via Task Scheduler, it exited with Last Run Result 0x101.

Probably it's due to Mica effect being implemented for title bar.

@valinet Can you update WinCenterTitle to support 22H2 build?

LazytownSpo666 commented 1 year ago

Unfortunately, @valinet did not respond to both of you for over the past months since WinCenterTitle 1.3.0.0 was released in 2021.

He currently left the repository for a while, to keep focusing on another (non-WinCenterTitle) project, named ExplorerPatcher, which is also created by him.

So if you want to wait for him to respond to you, and to add Win1122H2+ support for WinCenterTitle, you might as well just wait for 5-10 years.

ideapc commented 1 year ago

I confirm. Installed 22H2 today and found WinCenterTitle not working, even though it seems that its injected. I really hope it will be fixed; for me this tool is a must-have quality-of-life improvement.

stretch07 commented 1 year ago

Unfortunately, @valinet did not respond to both of you for over the past months since WinCenterTitle 1.3.0.0 was released in 2021.

He currently left the repository for a while, to keep focusing on another (non-WinCenterTitle) project, named ExplorerPatcher, which is also created by him.

So if you want to wait for him to respond to you, and to add Win1122H2+ support for WinCenterTitle, you might as well just wait for 5-10 years.

Okay then, we'll keep waiting. Let me know if there's a problem

mzso commented 1 year ago

@sysven32 commented on Sep 26, 2022, 10:27 PM GMT+2:

I have a same problem. Even though the cmd window says that WCT successfully injected library into DWM

WinCenterTitle
==============
1. Hook Library Path: C:\WinCenterTitle\WinCenterTitleLibrary.dll
2. Hook Library Entry Point: 0x1e20
3. LoadLibraryW address: -854741280
3. FreeLibrary address: -854754816
4. Found application, PID: 1084
5. Wrote library path in application's memory.
6. Successfully injected library into application.
7. Freed path from application's memory.
8. Found library in application's memory (113/116).
10. Successfully created message window (328536).
I

After a few secs, WinCenterTitle exited. I also tried running it via Task Scheduler, it exited with Last Run Result 0x101.

Probably it's due to Mica effect being implemented for title bar.

@valinet Can you update WinCenterTitle to support 22H2 build?

How do you run it as "system" and check the errors. In task scheduler it's shown as "running". But of course there's no way to view console output. Merely running it as admin gives an error: "4. ERROR: Cannot get handle to application."

mzso commented 1 year ago

By the way I'm on Windows 10. 22H2.

mzso commented 1 year ago

@ManiaSonicRUS commented on May 31, 2023, 3:28 PM GMT+2:

I confirm. Installed 22H2 today and found WinCenterTitle not working, even though it seems that its injected. I really hope it will be fixed; for me this tool is a must-have quality-of-life improvement.

Originally posted by @ManiaSonicRUS in https://github.com/valinet/WinCenterTitle/issues/23#issuecomment-1570236912

What OS Win 10 or 11?

LazytownSpo666 commented 1 year ago

@ManiaSonicRUS commented on May 31, 2023, 3:28 PM GMT+2:

I confirm. Installed 22H2 today and found WinCenterTitle not working, even though it seems that its injected. I really hope it will be fixed; for me this tool is a must-have quality-of-life improvement. Originally posted by @ManiaSonicRUS in #23 (comment)

What OS Win 10 or 11?

Both Windows 10 22H2 and Windows 11 22H2

MuscularPuky commented 1 year ago

@sysven32 commented on Sep 26, 2022, 10:27 PM GMT+2:

I have a same problem. Even though the cmd window says that WCT successfully injected library into DWM

WinCenterTitle
==============
1. Hook Library Path: C:\WinCenterTitle\WinCenterTitleLibrary.dll
2. Hook Library Entry Point: 0x1e20
3. LoadLibraryW address: -854741280
3. FreeLibrary address: -854754816
4. Found application, PID: 1084
5. Wrote library path in application's memory.
6. Successfully injected library into application.
7. Freed path from application's memory.
8. Found library in application's memory (113/116).
10. Successfully created message window (328536).
I

After a few secs, WinCenterTitle exited. I also tried running it via Task Scheduler, it exited with Last Run Result 0x101. Probably it's due to Mica effect being implemented for title bar. @valinet Can you update WinCenterTitle to support 22H2 build?

How do you run it as "system" and check the errors. In task scheduler it's shown as "running". But of course there's no way to view console output. Merely running it as admin gives an error: "4. ERROR: Cannot get handle to application."

you can run it manually with psexec.

MuscularPuky commented 1 year ago

wiat noone got to 11? i'm on 24H2 but not crashed

  1. Hook Library Entry Point: 0x1e20
  2. LoadLibraryW address: -2042256320
  3. FreeLibrary address: -2042269936
  4. Found application, PID: 1544
  5. Wrote library path in application's memory.
  6. Successfully injected library into application.
  7. Freed path from application's memory.
  8. Found library in application's memory (91/95).
  9. Successfully created message window (2755992). First time error while running entry point in DWM (256). Maybe symbols have changed, will try to download latest symbols, and rehook.
  10. Successfully hooked application.
  11. Registered for watching application. Listening for messages...
MuscularPuky commented 1 year ago

I have a same problem. Even though the cmd window says that WCT successfully injected library into DWM

WinCenterTitle
==============
1. Hook Library Path: C:\WinCenterTitle\WinCenterTitleLibrary.dll
2. Hook Library Entry Point: 0x1e20
3. LoadLibraryW address: -854741280
3. FreeLibrary address: -854754816
4. Found application, PID: 1084
5. Wrote library path in application's memory.
6. Successfully injected library into application.
7. Freed path from application's memory.
8. Found library in application's memory (113/116).
10. Successfully created message window (328536).
I

After a few secs, WinCenterTitle exited. I also tried running it via Task Scheduler, it exited with Last Run Result 0x101.

Probably it's due to Mica effect being implemented for title bar.

@valinet Can you update WinCenterTitle to support 22H2 build?

in source code 0x101 means GET_SYOMBOLS_ERROR.

if (VnGetSymbols(
                    szSettingsPath,
                    addresses,
                    symbolNames,
                    NUMBER_OF_REQUESTED_SYMBOLS
                ))
                {
                    FreeLibraryAndExitThread(
                        hModule, 
                        GET_SYMBOLS_ERROR
                    );
                    return GET_SYMBOLS_ERROR;
                }

and mine is not exited even after few sec. is this occurred ononly 22H2? any ideas?

mzso commented 1 year ago

@MuscularPuky commented on Jun 19, 2023, 1:53 PM GMT+2:

@sysven32 commented on Sep 26, 2022, 10:27 PM GMT+2: you can run it manually with psexec.

I'm unfamiliar with it. What command do you use?

emre93a commented 1 year ago

Is there a way to run this on w11 22h2 or when I looked through the codes, I didn't understand much

ideapc commented 1 year ago

@ManiaSonicRUS commented on May 31, 2023, 3:28 PM GMT+2:

I confirm. Installed 22H2 today and found WinCenterTitle not working, even though it seems that its injected. I really hope it will be fixed; for me this tool is a must-have quality-of-life improvement. Originally posted by @ManiaSonicRUS in #23 (comment)

What OS Win 10 or 11?

I am on Windows 11 22H2 (22621.1778) and yup I can't get it working. On 11 21H2 WinCenterTitle worked perfectly.

emre93a commented 1 year ago

@ManiaSonicRUS commented on May 31, 2023, 3:28 PM GMT+2:

I confirm. Installed 22H2 today and found WinCenterTitle not working, even though it seems that its injected. I really hope it will be fixed; for me this tool is a must-have quality-of-life improvement. Originally posted by @ManiaSonicRUS in #23 (comment)

What OS Win 10 or 11?

I am on Windows 11 22H2 (22621.1778) and yup I can't get it working. On 11 21H2 WinCenterTitle worked perfectly.

i found the reason for it in 22h2 CText::ValidateResources and CText::UpdateAlignmentTransform cannot center text because it has no values

emre93a commented 1 year ago

In 22H2, these values have changed, we need to find out where it is, then compile the wincentertitle project and add those codes into it so that the title text is centered.

mzso commented 1 year ago

@emre93a commented on Jul 5, 2023, 1:23 PM GMT+2:

In 22H2, these values have changed, we need to find out where it is, then compile the wincentertitle project and add those codes into it so that the title text is centered.

Yeah, but who is capable of that?

MuscularPuky commented 1 year ago

@emre93a commented on Jul 5, 2023, 1:23 PM GMT+2:

In 22H2, these values have changed, we need to find out where it is, then compile the wincentertitle project and add those codes into it so that the title text is centered.

Yeah, but who is capable of that?

I already tried last month but didnt have funchook

emre93a commented 1 year ago

@emre93a commented on Jul 5, 2023, 1:23 PM GMT+2:

In 22H2, these values have changed, we need to find out where it is, then compile the wincentertitle project and add those codes into it so that the title text is centered.

Yeah, but who is capable of that?

I already tried last month but didnt have funchook

ok you send me the project i'll take care of funchook either send the codes or the files I'll take care of the rest

scotdotwtf commented 1 year ago

i found a fork that has working funchook and libvalinet, i got it working and if you're trying to make a working fork of the project i would reccomend checking this out https://github.com/dkjnsdvsodvnosdvm/WinCenterTitle edit: only reason i wouldnt use it is because it has aero glass which can slow down window dragging sometimes

mzso commented 1 year ago

@scotdotwtf commented on Jul 18, 2023, 12:17 AM GMT+2:

i found a fork that has working funchook and libvalinet, i got it working and if you're trying to make a working fork of the project i would reccomend checking this out https://github.com/dkjnsdvsodvnosdvm/WinCenterTitle edit: only reason i wouldnt use it is because it has aero glass which can slow down window dragging sometimes

Originally posted by @scotdotwtf in https://github.com/valinet/WinCenterTitle/issues/23#issuecomment-1638964180

It works poorly. Looks bad for me. Got a translucent titlebar, with highlighted (brown background) text by the looks of it. Formerly It merely moved the text to the middle. It also messed up the desktop. The image and gadgets became blurred.

kép

mzso commented 1 year ago

Also dragging a window became slow motion with sever seconds of delay.

emre93a commented 1 year ago

i found a fork that has working funchook and libvalinet, i got it working and if you're trying to make a working fork of the project i would reccomend checking this out https://github.com/dkjnsdvsodvnosdvm/WinCenterTitle edit: only reason i wouldnt use it is because it has aero glass which can slow down window dragging sometimes

so does it work on windows 11 22h2?

scotdotwtf commented 1 year ago

while I don't know if it works on windows 11 22h2 I do want to say I agree it works poorly but the good thing is on there github you can see they have a (hopfully) fixed version of funchook: https://github.com/dkjnsdvsodvnosdvm/funchook. I think you could use this and other snippets from the other repository to develop a fixed version of WinCenterTitle.