search

valinet / libvalinet

A header-only collection of generic implementations shared between multiple projects
GNU General Public License v2.0
21 stars 8 forks source link

Fix VnGetUBR #3

Closed roflcopter4 closed 1 year ago

roflcopter4 commented 1 year ago

The value this function exists to retrieve wasn't being returned. This broke the new fix in Explorer Patcher for me.

valinet commented 1 year ago

It leaves one speechless to see how this went on for so long, seemingly working with me not noticing such a simple oversight. Thanks for the PR, much needed - that function is used in a TON of places.

roflcopter4 commented 1 year ago

It should really just be illegal to have a function with a non-void return type not end up returning anything. Just one of those holdovers from ancient C that won't die.

valinet commented 1 year ago

Yeah, coding in C is unforgiving. I have learned my lesson :D