search

valkey-io / valkey-container

valkey-container
BSD 3-Clause "New" or "Revised" License
68 stars 8 forks source link

Build default container images on AlmaLinux #21

Open jonathanspw opened 2 months ago

jonathanspw commented 2 months ago

Building the default container images on AlmaLinux would provide a stable base and remain valid for longer periods without needing major rebuilds of the images. Another benefit would be my active involvement in Valkey packaging and position within AlmaLinux should any issues arise.

Thoughts?

madolson commented 2 months ago

@hpatro @roshkhatri Can you look into this a bit and come up with a recommendation. AlmaLinux seems like a good base, but it's not something I know much about.

Conan-Kudo commented 2 months ago

I think it makes sense to make the default container AlmaLinux 8-based for maximum compatibility. AL8 has the benefit of being compatible enough to run on really old container hosts (which sadly I know exist) and support the full range of x86_64 CPUs. And since AlmaLinux 8 is also available for other major arches, it's relatively easy to offer multi-arch containers for Valkey using it.

madolson commented 2 months ago

I assume switching container bases is considered a "breaking" change, because of the compatibility comments you mentioned. I assume the logical time for us to switch would be in Valkey 8?

Conan-Kudo commented 2 months ago

Yes.