search

valkey-io / valkey-doc

Other
19 stars 25 forks source link

`/topics/functions-intro.md` has bad formatting, improper framing #104

Open stockholmux opened 1 month ago

stockholmux commented 1 month ago

In pre-publishing review (#91) I found the following issues on functions-intro.md

!KEYS and ARGV Lua APIs

Using the odd bang formatting which is invalid Valkey syntax.

Redis OSS v7.0 introduces Valkey Functions

Redis didn't introduce Valkey Functions :)

There are plans to support additional engines in the future.

Is this still true? It's probably best to remove forward looking statements in the documentation if there isn't some way to track it with an issue or roadmap item.

madolson commented 1 month ago

Is this still true? It's probably best to remove forward looking statements in the documentation if there isn't some way to track it with an issue or roadmap item.

No, this was Redis ltd. wording because they wanted to add javascript support to the main engine. We should drop this.