search

valkey-io / valkey-doc

Content for website and man pages
Other
23 stars 37 forks source link

Update cluster-spec with Valkey 8.0 cluster improvements #167

Closed PingXie closed 2 months ago

PingXie commented 3 months ago

Update cluster specification document to clarify shard migration process changes in Valkey 8.0 and include detailed descriptions of shard replication and failover mechanism improvements.

Fix #76

PingXie commented 3 months ago

Awesome. But isn't it more? What I remember, there were a lot of changes and long code comments with scenario descriptions which are useful material for docs, like these:

Wouldn't it be good to copy these example scenarios to the relevant sections in the cluster spec?

I wasn't sure how much detail we should add to the spec so went with just the "facts" but yeah good point on providing rationales as well. Will bring over some content.

btw, https://github.com/valkey-io/valkey/pull/245/files#diff-2515500619600c5a1e7a8d9aaa8761a6071314cd226c3b7ee4d0e054691f0a8eR3304 has been addressed by #754 and the comments have been removed (in #754 too).

PingXie commented 2 months ago

@madolson @zuiderkwast any more feedback? Let's merge this one in the next day or two?