Closed zuiderkwast closed 2 months ago
To review, it's probably best to try to brows the repo in github's web interface here on my branch: https://github.com/zuiderkwast/valkey-doc/blob/restored-topics-structure/topics/introduction.md
The idea is that the links should work. (Previously they only worked in the rendered website.)
This purpose is to make it easier for doc contributors and to make the docs more self-contained.
Details about renamed/moved files and updated links within the files.
Here is the Perl script. (Sorry, Perl is my native language for this kind of tasks. :grin:)
(If you want to try it, first mkdir topics
. Otherwise it doesn't work.)
Personally, I think we can merge this and get the website up. Then we can update it regularily later. The longer this kind massive (but somehow trivial) changes wait, the more merge conflicts and other trouble for this and other PRs.
Although that Perl is gnarly and I never want to see it again @zuiderkwast ;)
Awesome, thanks! Should we keep the individual commits? It makes it easier to see what's moved in one commit. (I can enable rebase-and-merge temporarily.)
Should we keep the individual commits?
Squash-merged. It's possible to go back to this PR to see each commit, if anyone ever wants to do that.
This massive change restores the
topics/page.md
structure of the doc repo, as it was a few years ago.It my not make sense to review this manually. If you do, you probably want to review one commit at a time. Renaming the files is done in one commit. Fixing the links is done in another commit.
This is done using a script that I can share. This is what it does:
docs/getting-started/installation/install-redis-from-source.md
->topics/install-valkey-from-source.md
.md
suffix. This makes it possible to click around in the github web interface. It's also good in other situations. For example, users can deploy the docs (simply .md -> .html) and don't need to deploy the docs in the root directory.Fixes #30