search

valkey-io / valkey-doc

Content for website and man pages
Other
21 stars 31 forks source link

512mb limit: No longer true? #97

Open stockholmux opened 4 months ago

stockholmux commented 4 months ago

Documentation lists 512mb on key and string sizes many times:

and probably more.

It appears the limitation was removed in 2021 see 4568 on redis. Looks like on issue 1653 on redis-doc there was a never merged issue to update this.

Can anyone confirm that Valkey is no longer subject to the 512mb limit?

madolson commented 4 months ago

As discussed, the 512MB limit is no longer a hard limit and can be changed with proto-max-bulk-len. I think we should frame it as, "it's untested to use a higher value than the default, please use at your own risk.

zuiderkwast commented 4 months ago

Why not do PRs directly instead of reporting as issues?

stockholmux commented 4 months ago

@zuiderkwast This is all linked to #91 which is a review process not necessarily an update process. This is so we don't block publishing of the website by waiting to fix dozens of issues.

If something looks super bad, I can suppress publishing until it's fixed, or alternately for not as bad pages, have a warning that says that we're working on it.

Once the review is finished: ready to publish.

zuiderkwast commented 4 months ago

OK, I just thought that in some cases, just posting the changes as a PR seems to be as small and fast as explaining them in an issue. It's sometimes a bit hard to know what exactly you want to be changed from these issues.

stockholmux commented 4 months ago

re: bit hard to know what exactly you want to be changed from these issues

Probably fair! I'll make sure and take another pass on my own issues.