Closed asafpamzn closed 1 month ago
I found the valkey scope npm owner and I gave him usernames so he will add us to the npm Valkey organization. im creating glide-valkey mail list and glide-valkey npm user. will save the password in the secret manager under the account 507286591552
Our valkey-glide account was added to the valkey organization by the valkey npm scope owner
https://github.com/valkey-io/valkey-glide/actions/runs/10759414515 first release candidate
the workflow version was wrong in the code and fixed.
https://github.com/valkey-io/valkey-glide/actions/runs/10769459827 the tests failed and fix. running again
https://github.com/valkey-io/valkey-glide/actions/runs/10772561798 release candidate is ready :)
There is an ssh issue in my EC2 that delays me from publishing a fix. working on it
ssh problem solved
new PR to release1.1 branch https://github.com/valkey-io/valkey-glide/actions/runs/10870387521
the PR merged
RC WF for npm - https://github.com/valkey-io/valkey-glide/actions/runs/10871422063 RC WF for pypi - https://github.com/valkey-io/valkey-glide/actions/runs/10871422062
some of the environments failed for both npm and pypi
Sync update: Status Red
Python - fixed by Yuri - https://github.com/valkey-io/valkey-glide/actions/runs/10895337144 . waiting to merge the fix to release-1.1 branch - https://github.com/valkey-io/valkey-glide/pull/2302#pullrequestreview-2308684261
Node - someone changed the createCluster api call 3 days ago and not fixed the RC tests. PR fix - https://github.com/valkey-io/valkey-glide/pull/2297 waiting for the workflow to finish - https://github.com/valkey-io/valkey-glide/actions/runs/10898579795/job/30242302580
npm update - https://github.com/valkey-io/valkey-glide/actions/runs/10899970218/job/30248492993 There is an API call (createCluster) that uses a function from another module (utils) that can't be imported. So, we're working on finding a solution to this.
@adarovadya We dont need to know the version for those tests, give it new Promise((resolve)=>resolve("255.255.255"))
and delete the import
const getServerVersion = new Promise((resolve)=>resolve("255.255.255"));
try {
console.log("Testing standalone Cluster")
console.log("Creating Cluster");
let valkeyCluster = await ValkeyCluster.createCluster(false,
1,
1,
getServerVersion,
);
(I might be wrong in some syntax, but general idea)
Java - There was an issue with the install-valkey step. Chloe working on a fix
npm rc passed with branch v1.1 - https://github.com/valkey-io/valkey-glide/actions/runs/10918974295/job/30305905338
npm passed with branch release-1.1 - https://github.com/valkey-io/valkey-glide/actions/runs/10921264671 pypi passed with branch py/rc-testing - https://github.com/valkey-io/valkey-glide/actions/runs/10921541501 - fix pr request by @avifenesh https://github.com/valkey-io/valkey-glide/pull/2314/files
Currently glide is under the name space glide-for-redis in NPM. We should change the namespace to Valkey-glide.