valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python
Apache License 2.0
260 stars 53 forks source link

NPM ValKey - Moving Glide Node package to ValKey name space and adjust CD #2041

Closed asafpamzn closed 1 month ago

asafpamzn commented 3 months ago

Currently glide is under the name space glide-for-redis in NPM. We should change the namespace to Valkey-glide.

adarovadya commented 2 months ago

I found the valkey scope npm owner and I gave him usernames so he will add us to the npm Valkey organization. im creating glide-valkey mail list and glide-valkey npm user. will save the password in the secret manager under the account 507286591552

adarovadya commented 2 months ago

Our valkey-glide account was added to the valkey organization by the valkey npm scope owner

adarovadya commented 2 months ago

https://github.com/valkey-io/valkey-glide/actions/runs/10759414515 first release candidate

adarovadya commented 2 months ago

the workflow version was wrong in the code and fixed.

https://github.com/valkey-io/valkey-glide/actions/runs/10769459827 the tests failed and fix. running again

adarovadya commented 2 months ago

https://github.com/valkey-io/valkey-glide/actions/runs/10772561798 release candidate is ready :)

adarovadya commented 2 months ago

done https://www.npmjs.com/package/@valkey/valkey-glide

adarovadya commented 1 month ago

PR https://github.com/valkey-io/valkey-glide/pull/2282/files

adarovadya commented 1 month ago

There is an ssh issue in my EC2 that delays me from publishing a fix. working on it

adarovadya commented 1 month ago

ssh problem solved

adarovadya commented 1 month ago

new PR to release1.1 branch https://github.com/valkey-io/valkey-glide/actions/runs/10870387521

adarovadya commented 1 month ago

the PR merged

adarovadya commented 1 month ago

RC WF for npm - https://github.com/valkey-io/valkey-glide/actions/runs/10871422063 RC WF for pypi - https://github.com/valkey-io/valkey-glide/actions/runs/10871422062

adarovadya commented 1 month ago

some of the environments failed for both npm and pypi

ikolomi commented 1 month ago

Sync update: Status Red

adarovadya commented 1 month ago

Python - fixed by Yuri - https://github.com/valkey-io/valkey-glide/actions/runs/10895337144 . waiting to merge the fix to release-1.1 branch - https://github.com/valkey-io/valkey-glide/pull/2302#pullrequestreview-2308684261

Node - someone changed the createCluster api call 3 days ago and not fixed the RC tests. PR fix - https://github.com/valkey-io/valkey-glide/pull/2297 waiting for the workflow to finish - https://github.com/valkey-io/valkey-glide/actions/runs/10898579795/job/30242302580

adarovadya commented 1 month ago

https://github.com/valkey-io/valkey-glide/actions/runs/10899970218

adarovadya commented 1 month ago

npm update - https://github.com/valkey-io/valkey-glide/actions/runs/10899970218/job/30248492993 There is an API call (createCluster) that uses a function from another module (utils) that can't be imported. So, we're working on finding a solution to this.

avifenesh commented 1 month ago

@adarovadya We dont need to know the version for those tests, give it new Promise((resolve)=>resolve("255.255.255")) and delete the import

    const getServerVersion = new Promise((resolve)=>resolve("255.255.255"));
    try {
        console.log("Testing standalone Cluster")
        console.log("Creating Cluster");
        let valkeyCluster = await ValkeyCluster.createCluster(false,
            1,
            1,
            getServerVersion,
        );

(I might be wrong in some syntax, but general idea)

adarovadya commented 1 month ago

Java - There was an issue with the install-valkey step. Chloe working on a fix

adarovadya commented 1 month ago

npm rc passed with branch v1.1 - https://github.com/valkey-io/valkey-glide/actions/runs/10918974295/job/30305905338

adarovadya commented 1 month ago

npm passed with branch release-1.1 - https://github.com/valkey-io/valkey-glide/actions/runs/10921264671 pypi passed with branch py/rc-testing - https://github.com/valkey-io/valkey-glide/actions/runs/10921541501 - fix pr request by @avifenesh https://github.com/valkey-io/valkey-glide/pull/2314/files